Skip to:

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#2404 closed defect (bug) (fixed)

[patch] Clean up bp_core_signup_send_validation_email()

Reported by: cnorris23's profile cnorris23 Owned by: djpaul's profile DJPaul
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Core Keywords: has-patch


The function, bp_core_signup_send_validation_email(), contains a lot of code from the function, bp_core_activation_signup_user_notification(), for WPMU. Some of this code is redundant. The $message_headers variable, for one, isn't needed, because wp_mail() gives the exact same results by default. The $from_name and $admin_email variables are already handled by the bp_core_email_from_name_filter() and bp_core_email_from_address_filter, respectively.

The filters for $to, $subject, and $message are named after the WPMU specific function.

It would also be nice to have some extra parameters for the $message filter so that the email can be more easily customized and personalized.

Attachments (1)

2404.001.diff (1.7 KB) - added by cnorris23 14 years ago.

Download all attachments as: .zip

Change History (6)

14 years ago

#1 @paulhastings0
14 years ago

  • Summary changed from Clean up bp_core_signup_send_validation_email() to [patch] Clean up bp_core_signup_send_validation_email()

#2 @DJPaul
14 years ago

  • Owner set to DJPaul
  • Status changed from new to assigned

I want to go over emails in a big way, so if that doesn't happen, we'll put something like this on.

#3 @DJPaul
14 years ago

See also #2745

#4 @boonebgorges
14 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3623]) Cleans up bp_core_signup_send_validation_email(). Fixes #2404. Props cnorris23. Also fixes some PHP warnings.

#5 @boonebgorges
14 years ago

Paul - I know that email overhauls are in the pipeline, but I figured not until after 1.4. Thus [3623].

Note: See TracTickets for help on using tickets.