Skip to:
Content

Opened 9 years ago

Closed 9 years ago

#2391 closed defect (bug) (fixed)

Gravatar email addresses appear to be case sensitive and therefore don't load properly.

Reported by: hotforwords Owned by:
Milestone: 1.2.5 Priority: normal
Severity: Version:
Component: Core Keywords: Gravatar has-patch needs-testing
Cc:

Description

Since I added Buddypress to my Wordpress installation, using the Buddypress plugin about 50% of my users lost their Gravatar image and we discovered that it has to do with an old Wordpress bug where the cases had to match between the email address on Gravatar and on the website. So joe@… and Joe@… would not match. Wordpress fixed this bug a while back.

The Gravatar's value is the hexadecimal MD5 hash of the requested users' email address with all whitespace trimmed. And the value is supposed to be case insensitive. (Taken from Wordpress Codex: http://codex.wordpress.org/Using_Gravatars) But it appears that Buddypress brings back this bug where the email address is suddenly case-sensitive for Gravatars.

Attachments (1)

2391.001.diff (6.7 KB) - added by cnorris23 9 years ago.

Download all attachments as: .zip

Change History (5)

#1 @beaulebens
9 years ago

Gravatar email addresses *are* case sensitive, and always have been. If you md5 a string with differing cases, it will create a different hash and therefore not resolve properly on Gravatar.

Emails *must* be lowercased before hashing them to request a Gravatar.

$hash = md5( strtolower( $email ) );

#2 @cnorris23
9 years ago

  • Keywords has-patch needs-testing added

@hotforwords
I've gone through and added strtolower per beaulebens' comment. Give the patch a test, and make sure everything works.

@cnorris23
9 years ago

#3 @johnjamesjacoby
9 years ago

  • Milestone changed from 1.3 to 1.2.5

#4 @johnjamesjacoby
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3026]) Fixes #2391 props cnorris23, beaulebens, alot

Note: See TracTickets for help on using tickets.