Skip to:
Content

BuddyPress.org

Opened 16 years ago

Closed 16 years ago

Last modified 10 years ago

#2347 closed defect (bug) (fixed)

Mini activity comment gap between post box

Reported by: erich73 Owned by: sushkov
Priority: trivial Milestone: 1.5
Component: Templates Version: 1.5
Severity: Keywords: has-patch
Cc: stas@…

Description

just a small style issue:

not sure why there is a distance at the permalink-page (only when replying to someones activity like Group-Join).
When replying to posts, then there is no distance which looks better.

Please see Screenshot attached.

Attachments (3)

permalink_page_style.gif​ (40.2 KB ) - added by erich73 16 years ago.
bp_2347_stas.diff​ (477 bytes ) - added by sushkov 16 years ago.
2347.1.3-bleeding.patch​ (434 bytes ) - added by r-a-y 16 years ago.
Refreshed patch against v1.3-bleeding

Download all attachments as: .zip

Change History (12)

@erich73
16 years ago

#1 @sushkov
16 years ago

  • Keywords dev-feedback added

Looks fixed to me.
Here's a screenshot using trunk:
​http://i.imgur.com/0PWnL.png

#2 @sushkov
16 years ago

  • Cc stas@… added

#3 @erich73
16 years ago

@sushkov,

no, this issue is not fixed.
I am talking about "Group Join" activity.

Your screenshot is showing another activity.

@sushkov
16 years ago

#4 @sushkov
16 years ago

  • Keywords has-patch needs-testing added; dev-feedback removed
  • Owner set to sushkov
  • Status new → assigned

Works for me in FF 3.6 on Linux, also in some dev version of Chromium (except it is rendered a bit narrowed). Needs feedback from Windows users and a stable Chrome version.

#5 @johnjamesjacoby
16 years ago

  • Milestone 1.2.4 → 1.3

This issue arises when the activity text is smaller in height than the user avatar on the left.

Bumping to 1.3 as this is a minor issue.

#6 @paulhastings0
16 years ago

  • Summary page style at permalink-page → [patch] page style at permalink-page

@r-a-y
16 years ago

Refreshed patch against v1.3-bleeding

#7 @r-a-y
16 years ago

  • Component Activity → Theme
  • Keywords needs-testing removed
  • Summary [patch] page style at permalink-page → Mini activity comment gap between post box
  • Type enhancement → defect
  • Version → 1.3

#8 @djpaul
16 years ago

  • Resolution → fixed
  • Status assigned → closed

(In [3535]) Fix paddings on activity permalink page. Fixes #2347, props r-a-y

#9 @DJPaul
10 years ago

  • Component Appearance - Template Parts → Templates
Note: See TracTickets for help on using tickets.