Skip to:
Content

BuddyPress.org

Opened 9 years ago

Closed 9 years ago

#2323 closed defect (bug) (no action required)

Missing a hook in bp-themes/bp-default/members/single/plugins.php

Reported by: jeffsayre Owned by: jeffsayre
Milestone: 1.2.5 Priority: normal
Severity: Version:
Component: Core Keywords: Members theme, has-patch, needs-testing
Cc:

Description

In order for the titles of settings screens to appear, this hook is required. It used to exist in the older bp-sn-parent theme files. Without this hook, 3rd-party component's setting screens that use the following skeleton component coding will fail to show the screen title:

add_action( 'bp_template_title', 'xxx' );
add_action( 'bp_template_content', 'xxx' );

A patch file is included.

Attachments (1)

jeffsayre_2323_members_theme.patch (635 bytes) - added by jeffsayre 9 years ago.

Download all attachments as: .zip

Change History (7)

#1 @jeffsayre
9 years ago

  • Owner set to jeffsayre
  • Status changed from new to assigned

#2 @johnjamesjacoby
9 years ago

  • Milestone changed from 1.2.4 to 1.3

Not missing but omitted from bp-default entirely.

No component has a title in bp-default (with the exception of Email Notifications.)

Bumping this to 1.3 for further review of page titles as a whole.

#3 @jeffsayre
9 years ago

This hook used to be in the old theme and is used in the Skeleton Component as one example of how to create a settings screen for your component. I used it in the my old Privacy Component (the one that worked with BP v 1.1.3. This hook remains in the new version of my Privacy Component as it is needed to display the title for each Settings screen.

#4 @jeffsayre
9 years ago

  • Milestone changed from 1.3 to 1.2.5

I'm changing this back to 1.2.5 as the call to this hook is not only used in the current Skeleton Component but also called in four places in BP Core. Search for 'bp_template_file' in BP core and you will find that bp-core-settings.php calls it 3 times and bp-groups-classes.php calls it once.

Since, it is used in core, the hook should be added back into the template file. Also, there are a number of people designing new BP components based on the Skeleton Component. The call to that hook is used in the example settings screens functions.

#5 @jeffsayre
9 years ago

  • Keywords has-patch needs-testing added; removed

#6 @jeffsayre
9 years ago

  • Resolution set to invalid
  • Status changed from assigned to closed

Just tested with newest stable BP version. This patch is no longer needed. So, I'm setting it to resolved as invalid.

Note: See TracTickets for help on using tickets.