Skip to:

Opened 14 years ago

Closed 14 years ago

#2304 closed defect (bug) (no action required)

2 errors in bp-templatetags.php

Reported by: chouf1's profile chouf1 Owned by:
Milestone: 1.2.4 Priority: major
Severity: Version:
Component: Core Keywords: has-patch


Two errors line 672 and 674
672: %s to be escaped
$pag_filter = sprintf( ( ' matching tag "%s"', 'buddypress' ), $forum_template->search_terms );
$pag_filter = sprintf(
( ' matching tag \"%s\"', 'buddypress' ), $forum_template->search_terms );

674: trailing %s
echo apply_filters( 'bp_forum_pagination_count', sprintf( ( 'Viewing topic %s to %s (%s total topics%s)', 'buddypress' ), $from_num, $to_num, $total, $pag_filter ) );

echo apply_filters( 'bp_forum_pagination_count', sprintf( ( 'Viewing topic %s to %s (%s total topics)', 'buddypress' ), $from_num, $to_num, $total, $pag_filter ) );

Change History (3)

#1 @DJPaul
14 years ago

  • Keywords has-patch added

Why does the first one need to be escaped, please?

#2 @chouf1
14 years ago

;-) basically: no reason to do this.
it was probably my poEdit who mistake or bug.

#3 @johnjamesjacoby
14 years ago

  • Resolution set to invalid
  • Status changed from new to closed

They all rolled over and one fell off.

Note: See TracTickets for help on using tickets.