Skip to:

Opened 14 years ago

Closed 14 years ago

#2302 closed defect (bug) (fixed)

missing translation in comments.php

Reported by: chouf1's profile chouf1 Owned by:
Milestone: 1.2.4 Priority: major
Severity: Version:
Component: Core Keywords: has-patch


in bp-themes/bp-default/comments.php the string line 23 is not translatable actually (and since v. 1.2 )

Replace :
<h3 id="comments"><?php comments_number( 'No Comments', 'One Comment', $numComments . ' Comments' );?></h3>


<h3 id="comments"><?php comments_number( ( ('No Comments &#187;','buddypress')), ( ('1 Comment &#187;','buddypress')), ( ('% Comments &#187;','buddypress')) );?></h3>

The changes are done to reflect the existing expressions in pot file

Change History (4)

#1 @smurfdev
14 years ago

rather change it to:

<h3 id="comments"><?php comments_number();?></h3>

Translations are done in the wordpress comments_number() function with default parameter values.

#2 @chouf1
14 years ago

... and this means that we don't need to use BP's parameters...

I tested and this more simple and elegant solution works too. Thanks !

#3 @DJPaul
14 years ago

  • Keywords has-patch added

#4 @johnjamesjacoby
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2931]) Fix #2302

Note: See TracTickets for help on using tickets.