'friends_install' check is breaking a lot of stuff on the trunk

[boonebgorges]

Please feel free to close this ticket if it's a work-in-progress. I didn't find any info when I searched.

I noticed that a bunch of friend-related stuff in trunk is not working, due to the fact that the function friends_install() has been taken out of bp-friends.php. There are a number of places that use if ( function_exists( 'friends_install' ) ) to check for the existence of the friends component:

• displaying the proper friendship request button (request pending/add friend/cancel friendship/etc) on member lists
• displaying the Send Invites link on group pages
• displaying a list of friends to invite to a group

None of these are working on trunk (rev 2912).

Maybe this is part of the new installation procedure Andy's working on? If so, and if the function friends_install is no longer going to be part of the picture, then the friend component check will have to be changed.

[johnjamesjacoby]

A lot of function_exists checks will be replaced by an internal function to handle the verification that BuddyPress components are on/off. MrMaz has already started handling some of these issues in the trunk and there are surely more fixes to follow.

Thanks for the heads up Boone!

[DJPaul]

Is this new function going to be in 1.2.4 or 1.3?

[r-a-y]

It's in trunk as of [2919] by Andy.

[boonebgorges]

2sweet dawg :)

[johnjamesjacoby]

It will be in 1.3.

1.2.4 will be a very minimal bug fix release.

[boonebgorges]

Andy's revisions were wiped out on [2925]. Is this right?

[DJPaul]

friends_install is no longer in trunk, so closing this as fixed. See also #2718.