Skip to:
Content

Opened 4 years ago

Closed 3 years ago

#2299 closed enhancement (wontfix)

[patch] Improve support for IIS-style WordPress URLs

Reported by: bsweeney Owned by:
Milestone: 1.5 Priority: minor
Severity: Version:
Component: Core Keywords: needs-testing
Cc:

Description

I'm working to implement BuddyPress on a Windows server using IIRF to support URL rewriting. There is an issue, however, in the way IIRF passes URLs back to IIS for further processing. When BuddyPress looks at the URL it sees the index.php portion and includes it as part of the path.

A simple patch to bp-core-catchuri.php seems to fix this, see the attached diff. I think modification would move BuddyPress closer to full support for IIS. The fix is rather simplistic in that it looks for the presence of index.php. It might be a good idea to make this an optional setting.

Ideally, I would like to also see BuddyPress modified to take into account the permalink structure used by WordPress on IIS when no URL rewriting is available. That would require the inclusion of index.php at the front of any BuddyPress-generated URLs. This could be enabled by the same setting that enables the above fix.

I plan to stick with IIRF, but these changes might help others attempting to implement BP on IIS.

Attachments (1)

iis.patch (747 bytes) - added by bsweeney 4 years ago.

Download all attachments as: .zip

Change History (9)

bsweeney4 years ago

comment:1 DJPaul4 years ago

  • Milestone changed from Future Release to 1.3

Maybe JJJ can look at this since I know he works on IIS servers.

comment:2 paulhastings04 years ago

  • Summary changed from Improve support for IIS-style Wordpress URLs to [patch] Improve support for IIS-style Wordpress URLs

comment:3 paulhastings04 years ago

  • Summary changed from [patch] Improve support for IIS-style Wordpress URLs to [patch] Improve support for IIS-style WordPress URLs

comment:4 DJPaul3 years ago

This could go in as-is, but BP would still break on subdirectory installs; see #1726 for related discussion.

comment:6 DJPaul3 years ago

  • Keywords needs-testing added; iis removed

If someone who has a test box that runs these 'almost pretty' permalinks, we can put it into 1.3, otherwise it will get punted.

comment:7 DJPaul3 years ago

  • Priority changed from normal to minor

comment:8 DJPaul3 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

This was discussed at length in dev chat. We have no IIS install to test this patch on, and it only solves half the problem, anyway.The URL would still be generated missing the index.php prefix. Custom post types in 1.4 will get rid of this problem for us.

Current solutions involving rewriting the URL should continue to work.

Note: See TracTickets for help on using tickets.