argument swapping on all BP __ and _e calls where applicable

[DJPaul]

Built on rev 2904 of the 1.2 branch. Also touched up a couple of code-style issues.

[DJPaul]

Please would someone look at this before it goes stale. It just adds argument swapping to all and _e calls. i.e.

`
sprintf( ( "Hello %$1s, it is %$2s today", 'buddypress' ), 'Paul', 'sunny' );

Can be translated as "Hello Paul, it is sunny today" or "Hello sunny, it is Paul today".
`

[johnjamesjacoby]

Do you mind combing through this one more time?

I found a '1$%s' in your patch, which means no cake for you, yet. :)

Outstanding work though, and a long time coming.

[DJPaul]

v2

[DJPaul]

v2 resolves that. I couldn't find any other errors.

[johnjamesjacoby]

Awesome. I like it.

[johnjamesjacoby]

(In [2941]) Fixes #2291 props DJPaul

[francescolaffi]

Not sure about this but I think that the 2941 changeset is wrong in some points: it changes lot of %s to %*$d , sometimes a number is passed as string because is formatted from bp_core_number_format that add a comma as thousands separator so it must be s not d, otherwise it will trunk numbers after the comma if the number passed is > 999

[johnjamesjacoby]

(In [2944]) Properly reset format strings from r2941. Fixes #2291 again. Props francescolaffi.