Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 11 years ago

#2280 closed defect (bug) (fixed)

Need do_action at end of bp_core_add_settings_nav

Reported by: lunabyte Owned by:
Milestone: 1.5 Priority: normal
Severity: Version:
Component: Core Keywords:
Cc:

Description

In ./bp-core/bp-core-settings.php, the function bp_core_add_settings_nav() is missing a do_action call at the end of the function, similar to the other nav setup functions for activity, profile, etc.

Other similar functions have this hook, and it seems that without it when you attempt to add an additional subpage with bp_core_new_subnav_item, the link will show up, but when clicked redirects to the home page.

Adding the following to the end of the function restores functionality to expected behavior.

do_action('bp_settings_setup_nav');

Change History (5)

#1 @r-a-y
12 years ago

Related: #2249

#2 @r-a-y
12 years ago

Actually scratch that! Didn't see the "nav" part!

#3 @johnjamesjacoby
12 years ago

  • Milestone changed from 1.2.4 to 1.3

bp-settings is in need of a makeover. This function does need a hook, but it also needs to be broken apart into several functions similar to the other components, which means there is other refactoring to think about.

I'm moving this to 1.3 so it's off the 1.2.4 timeline. We'll get to bp-settings soon though.

#4 @boonebgorges
11 years ago

I agree with jjj that bp-settings needs some reworking but I don't that should stop us from providing the requested hook. The nav setup function itself is not that different from the other components.

#5 @boonebgorges
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3487]) Adds do_action hook to bp_core_add_settings_nav(). Fixes #2280. Props lunabyte

Note: See TracTickets for help on using tickets.