[patch] bp_core_set_uri_globals() doesn't properly return on WP page

[cnorris23]

The function, bp_core_set_uri_globals() is set to return false, if you're on a WP page starting at line 122 of bp-catch-uri.php.

/* This is not a BuddyPress page, so just return. */
if ( in_array( 0, (array) $matches ) )
	return false;

However, the function can never return false, as $matches is unset in the preceding foreach statement if there is no match to a BP page.

[cnorris23]

Yep, past my bedtime :/. The first patch was crap, and should have never been posted. It can be ignored.

[johnjamesjacoby]

Some changes have taken place to this function that should stop this from happening.

Can you try out the latest branch of code and see if it's fixed for you now? The code in your patch actually no longer exists in the 1.2 branch of code.

[cnorris23]

It's still an issue for trunk, as of [2899]. In fact the exact same code is in both the 1.2 branch, and trunk. They're even on the same line ;). I was in the process of trying to make patches to clean up all the errors in WP_DEBUG when I came across this. I'm not trying to do anything that requires the fix, so this can be bumped to 1.3. Fixing this stops the function from unnecessarily running it's course, and helps to cut down on some undefined variable WP_DEBUG messages.

[cnorris23]

updated for trunk

[johnjamesjacoby]

Bumping to 1.3 as code does not exist in branch, and this function is changing for 1.3 in trunk, since root components are being deprecated in lieu of page templates.

[djpaul]

(In [3324]) Fixes #2247