Skip to:
Content

Opened 9 years ago

Closed 23 months ago

#2234 closed enhancement (wontfix)

Put bp_insert_activity_meta in it's own div or span so it's easier to style

Reported by: 21cdb Owned by: tw2113
Milestone: Priority: minor
Severity: normal Version:
Component: Activity Keywords:
Cc: email@…

Description

Hi Andy,

small thing related to the Activity stream entries. It would be great if you could put a div class="something" around the bp_insert_activity_meta function in bp-activity-templatetags.php line 488 so that theme designers could style time since, permalink and the delete link and the Dots in between them more simply.

Attachments (1)

Bildschirmfoto 2010-03-23 um 23.03. | 01.32.44.png (24.9 KB) - added by 21cdb 9 years ago.

Download all attachments as: .zip

Change History (13)

#1 @erich73
9 years ago

agree.
I would like to place this information in the next line.
It should not be in the same "<p>" tag.

#2 @johnjamesjacoby
9 years ago

  • Milestone set to 1.3

#3 @boonebgorges
8 years ago

I agree that the markup here is not very appealing but I would like some feedback from other devs before making big markup changes. The markup looks like this right now:

<div class="activity-header"> 
	<p>
		<a href="http://example.com/members/boone/" title="boone">boone</a> posted an update: <span class="time-since">&nbsp; 33 minutes ago</span> &middot; <a href="http://example.com/activity/p/17/" class="view" title="View Thread / Permalink">View</a> &middot; <a href="http://example.com/activity/delete/17?_wpnonce=b302b9d11d" class="item-button delete-activity confirm">Delete</a>
	</p>		
</div>

I think it should probably look like this:

<div class="activity-header"> 
	<span class="activity-action"><a href="http://example.com/members/boone/" title="boone">boone</a> posted an update:</span> 
	
	<span class="activity-meta">
		<span class="time-since">&nbsp; 33 minutes ago</span> &middot; <a href="http://example.com/activity/p/17/" class="view" title="View Thread / Permalink">View</a> &middot; <a href="http://example.com/activity/delete/17?_wpnonce=b302b9d11d" class="item-button delete-activity confirm">Delete</a>
	</span>
</div>

(spacing exaggerated for effect)
Does this strike others as a logical way to break up the markup?

#4 @boonebgorges
8 years ago

  • Keywords dev-feedback added; bp_insert_activity_meta removed

#5 @DJPaul
8 years ago

  • Keywords has_patch removed

Something like that looks ok as long as it doesn't inadvertently change any styling.

#6 @DJPaul
8 years ago

  • Milestone changed from 1.3 to Future Release

#7 @DJPaul
7 years ago

  • Keywords dev-feedback removed
  • Severity set to normal

This ticket was mentioned in Slack in #buddypress by djpaul. View the logs.


3 years ago

#9 @tw2113
2 years ago

  • Owner set to tw2113
  • Status changed from new to assigned

Given the hierarchy of the HTML, I think the only way we could potentially break anything, is if we were to remove the <p> as a whole. <span> tags inside it will be just fine, and any selectors relying on the <p> tag will still work. The only way they may not, would be if someone was doing a direct descendant selector for the <a> tags, which would be a bit extreme.

#10 @tw2113
23 months ago

@mercime @hnla How pertinent is this ticket likely to be at this point, with BP-Nouveau incoming in the near future? Want to make sure I don't use more time than I should on it.

#11 @mercime
23 months ago

@tw2113 At this point, I think the time for adding a new <span> to style the first half of the <div class="activity-header"> has passed IMHO. The only <span> that's currently in bp-legacy within div.activity-header has been updated in bp-nouveau with the semantic HTML5 <time> element.

#12 @tw2113
23 months ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

Thanks, going to mark it as closed in response.

Keep an eye out for bp-nouveau, everyone, it's going to be great.

Note: See TracTickets for help on using tickets.