Skip to:
Content

Opened 9 years ago

Closed 8 years ago

#2217 closed enhancement (no action required)

CSS font style

Reported by: erich73 Owned by:
Milestone: 1.5 Priority: trivial
Severity: Version:
Component: Activity Keywords:
Cc:

Description

seems this is hard-coded:
Please move this into CSS-code:

div class=activity-inreplyto
< strong > in Reply to < strong >

Change History (6)

#1 @cnorris23
9 years ago

  • Resolution set to invalid
  • Status changed from new to closed

The use of the strong tag is correct. If you aren't happy with how is displayed, then you can style it with your own CSS rules, or you can remove it on your child theme. Tags such as strong and em are used to give hints to screen readers.

#2 @erich73
9 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

@cnorris23

are you sure you are allowed and assigned to close tickets ?

This is hard-coded and not within CSS.

#3 @calvin_42
9 years ago

I agree with cnorris23 : strong tag and CSS have nothing in common. Strong has a semantic meaning.

Please use :

.activity-inreplyto strong {
	font-weight:normal;
}

#4 @r-a-y
9 years ago

Perhaps it should be a <span> tag with a class added to it?
eg. <span class="reply-to">in Reply to</span>

Use of the <strong> tag is if you want to place emphasis on something.
And I don't see why "in Reply to" should be emphasized.

#5 @cnorris23
9 years ago

r-a-y's solution would work, but you lose a little accessibility.

@ray,
screen readers use it to add vocal emphasis to text, and in this case it would be used to emphasize that the following text is "in reply to," thereby distinguishing it from a regular comment. Now, whether this was the original intention, I don't know ;).

@erich73,
I can see that it's hard coded. My point was that you can still style it however you choose through the very CSS calvin_42 wrote, and the emphasis is still there for screen readers. It's the best of both worlds.

#6 @boonebgorges
8 years ago

  • Resolution set to invalid
  • Status changed from reopened to closed

I agree with cnorris23 that in this case the markup is semantically appropriate.

Note: See TracTickets for help on using tickets.