Opened 16 years ago
Closed 16 years ago
#2153 closed defect (bug) (duplicate)
Move bp_core_override_adminbar_css() to wp_head
| Reported by: | r-a-y | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.2.3 |
| Component: | Version: | ||
| Severity: | Keywords: | ||
| Cc: |
Description
Right now, bp_core_override_adminbar_css() contains a [style] tag, which is called in wp_footer.
Style tags shouldn't be in the [body].
The action should be called in wp_head with a priority of 100 so the CSS is called near the end of wp_head.
Modify line 182 of /bp-core/bp-core-cssjs.php to:
add_action( 'wp_head', 'bp_core_override_adminbar_css', 100 );
Change History (4)
#2
@
16 years ago
- Resolution duplicate
- Status closed → reopened
I'm flip-flopping!
Though #2024 is related, this ticket addresses the hook and priority of the function, while the other ticket discusses the removal of the function altogether.
#3
@
16 years ago
Moving it to wp_head would indeed fix that HTML validation issue, however the function then still does not serve a purpose, as it adds CSS that will never to anything. (I explained that further here.)
However, if the function is not deprecated, moving it to wp_head should be considered instead, as r-a-y correctly suggests.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Closing this.
There's another ticket that is similar - #2024.