Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

#2153 closed defect (bug) (duplicate)

Move bp_core_override_adminbar_css() to wp_head

Reported by: r-a-y's profile r-a-y Owned by:
Milestone: 1.2.3 Priority: minor
Severity: Version:
Component: Keywords:
Cc:

Description

Right now, bp_core_override_adminbar_css() contains a [style] tag, which is called in wp_footer.

Style tags shouldn't be in the [body].

The action should be called in wp_head with a priority of 100 so the CSS is called near the end of wp_head.

Modify line 182 of /bp-core/bp-core-cssjs.php to:

add_action( 'wp_head', 'bp_core_override_adminbar_css', 100 );

Change History (4)

#1 @r-a-y
14 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

Closing this.

There's another ticket that is similar - #2024.

#2 @r-a-y
14 years ago

  • Resolution duplicate deleted
  • Status changed from closed to reopened

I'm flip-flopping!

Though #2024 is related, this ticket addresses the hook and priority of the function, while the other ticket discusses the removal of the function altogether.

#3 @TobiasBg
14 years ago

Moving it to wp_head would indeed fix that HTML validation issue, however the function then still does not serve a purpose, as it adds CSS that will never to anything. (I explained that further here.)

However, if the function is not deprecated, moving it to wp_head should be considered instead, as r-a-y correctly suggests.

#4 @r-a-y
14 years ago

  • Resolution set to duplicate
  • Status changed from reopened to closed

Closing my own thread again! I agree with #2024. bp_core_override_adminbar_css() should be removed.

Note: See TracTickets for help on using tickets.