Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

Last modified 6 years ago

#2151 closed enhancement (fixed)

don't use global variable j in bp-themes/bp-default/_inc/globals.js for jQuery [has-patch]

Reported by: andrew_s1's profile andrew_s1 Owned by:
Milestone: 1.2.3 Priority: minor
Severity: Version:
Component: Activity Keywords: has-patch
Cc: wordpress@…

Description

It's just asking for trouble. People are always going to use i and j as handy counter variables, so it's not wise to rely on having j in the global namespace as an untainted jQuery object

Attachments (1)

globaljs.patch (2.0 KB) - added by andrew_s1 12 years ago.

Download all attachments as: .zip

Change History (4)

@andrew_s1
12 years ago

#1 @andrew_s1
12 years ago

  • Cc wordpress@… added
  • Component set to Activity
  • Priority changed from trivial to minor
  • Summary changed from don't use global variable j in bp-themes/bp-default/_inc/globals.js for jQuery to don't use global variable j in bp-themes/bp-default/_inc/globals.js for jQuery [has-patch]

#2 @apeatling
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2861]) Change jQuery var from j to jq to avoid potential iterator conflicts. Fixes #2151 props andrew_s1

#3 @DJPaul
6 years ago

  • Type changed from task to enhancement
Note: See TracTickets for help on using tickets.