When deleting activity in permalink view page should redirect back to stream

[modemlooper]

If you delete a view the page just stays static and blank. It would be better if the page went back to the activity stream.

[r-a-y]

Changing type to defect and priority to major as this is a big usability issue.

[cnorris23]

This is a first pass. It gets the basic functionality down, but the redirect variable probably needs to be sanitized. Sanitizing will need to be done in global.js, and javascript is not my strong suite. I know WP has the function wp_sanitize_redirect(), but I'm not sure how to implement it in js.

[boonebgorges]

The patch is a good start. If the redirect is going to happen with JS (something that doesn't appear to happen anywhere else in BP, fwiw), it does need to be sanitized. (JS is not my strong suit either.) Or we could just remove the ajax delete from single activity items, so that the redirect happens in PHP. That way we don't have to worry about sanitization.

There's also a little funkiness with using wp_get_referer() for the redirect address, which I discovered as I was refreshing the page over and over again, and so the bp_redirect_url was set to the single activity item :)

[cnorris23]

redirect via query arg

[cnorris23]

Updated patch to redirect single activity items in PHP rather than javascript

edit: Also adds some PHPdoc

[DJPaul]

I don't think the attached patch is the best approach, but this could do with getting fixed for 1.3 as it's not ideal right now.

[cnorris23]

Do you have any direction on how you think it should be done?

[DJPaul]

I think I must have taken a quick look at the 001 patch, sorry. 002 is good. For 1.3, the patch could now use bp_get_root_domain(), bp_is_single_activity(), and perhaps bp_activity_get_permalink() as that will take care of the root_slug changes, too :)

[cnorris23]

Alrighty. I'll whip it up :)

[cnorris23]

Updating patch

[DJPaul]

Going to put this patch in shortly -- just working on a bit of tidy up of nearby code, too

[DJPaul]

Updated patch attached; 90% the same as cnorris23's 2002.003.diff.

It works fine with no AJAX, but it doesn't redirect with AJAX. Might need to take the approach as in 2002.001.diff for that. However, it also seemed inelegant that a lot of bp_activity_action_delete_activity() is duplicated in bp_dtheme_delete_activity(), so I started trying to add an optional argument into bp_activity_action_delete_activity(), and manually set $bp->action = 'delete' in bp_dtheme_delete_activity(), but it didn't seem to work. I've left that in the patch, and ideas welcome

[cnorris23]

As Boone suggested (comment:10) we could just avoid the ajax altogether and let the redirect happen in php only. We don't really need the ajax delete on a single activity page anyway. Paul, I've updated your updated patch ;) to include an easy fix. Not great on back-compat, but the impact should be minimal. Since, jquery is listening for clicks with the 'delete-activity', we can just set things to 'delete-activity-single' to avoid the click event. A little hackish maybe, but it doesn't cause any design/layout issues in bp-default.

[boonebgorges]

I think 2002.005.diff is pretty close. I definitely prefer removing the AJAX delete, which is silly in the case of single items.

I thought maybe it would be possible to change the JS so it wouldn't be listening for the click, but since it's done by delegation on the parent, changing the CSS class is probably the only easy way to fix it. I think the backpat considerations are probably pretty minimal. DJPaul, what do you think?

[DJPaul]

Patch seems to work fine, and it's good and tasty.

[boonebgorges]

(In [4337]) Redirects user back to activity stream after single activity item delete. Removes AJAX from delete link on activity permalink page. Fixes #2002. Props cnorris23