Core: Option to use user_nicename instead of user_login in member urls/atme

[nuprn1]

I ran into the same issue as
http://buddypress.org/forums/topic/characters-in-usernames-cause-strange-issues

When certain member's user_login contained @ (email address, special char, etc) - there was some quirkiness with member urls and the slug. Going off the concept that bbPress uses the user_nicename for member profiles this would be a nice option.

The changes I made to my core files (i don't recommend running this patch)
​http://blog.etiviti.com/2010/02/forcing-buddypress-to-use-user_nicename-for-member-urls-and-mentions/

Maybe piggyback off the BP_ENABLE_USERNAME_COMPATIBILITY_MODE flag?

[apeatling]

By default it uses user_nicename, with BP_ENABLE_USERNAME_COMPATIBILITY_MODE it uses user_login.

[DJPaul]

The fix for #1992 may fix this for new user names - haven't tested.

[DJPaul]

This might be related to #2670

[DJPaul]

I am closing this because BuddyPress (trunk, at least) does use the nicename in URLs. You have to set the compat mode to force it to use the user login. There is an outstanding issue on #2670 regarding email addresses when they are set as user_login. Other than that, I've been looking at this recently and believe everything is now consistent, so I'm closing the ticket.