Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

#1959 closed defect (bug) (fixed)

No-ajax search should 'return' not 'return false' [Has-patch]

Reported by: rvenable's profile rvenable Owned by:
Milestone: 1.2 Priority: minor
Severity: Version:
Component: Keywords:
Cc:

Description

In global.js:

j('div.dir-search').click( function(event) {
		if ( j(this).hasClass('no-ajax') )
			return false;

Return false doesn't allow the search to function as normal even though it has the no-ajax class. I think just a simple return would be better.

Attachments (1)

return.diff (411 bytes) - added by rvenable 14 years ago.

Download all attachments as: .zip

Change History (3)

@rvenable
14 years ago

#1 @rvenable
14 years ago

The other no-ajax checks just do a simple return, so they work fine

#2 @apeatling
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2727]) Fixes #1959 props rvenable

Note: See TracTickets for help on using tickets.