Skip to:
Content

BuddyPress.org

Opened 10 years ago

Closed 4 years ago

#1949 closed enhancement

Refactor notification emails

Reported by: johnjamesjacoby Owned by: DJPaul
Milestone: Priority: major
Severity: normal Version:
Component: Core Keywords:
Cc: johnjamesjacoby

Description

Changeset r2697 added filters for wp_mail calls in BuddyPress. These filters don't fire until after the sprintf is already called, so they don't really work the way they're intended.

This patch now allows them to be filtered, and cleans up all of the notification code.

(This should probably be cleaned up further and turned into an API for 1.3.)

Attachments (1)

wp_mail_filter_refactor_for_r2697.patch (39.5 KB) - added by johnjamesjacoby 10 years ago.
What you gonna do with all this patch? All this patch inside this ticket?

Download all attachments as: .zip

Change History (15)

@johnjamesjacoby
10 years ago

What you gonna do with all this patch? All this patch inside this ticket?

#1 @apeatling
10 years ago

There are too many other unrelated changes in this patch to commit it this late in the game. For example the filter_kses calls need to stay on the content.

#2 @apeatling
10 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2719]) Fixes #1949

#3 @DJPaul
10 years ago

  • Milestone changed from 1.2 to Future Release
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Type changed from defect to enhancement

Reopening as enhancement to improve this for future release

#4 @DJPaul
10 years ago

  • Owner changed from apeatling to DJPaul
  • Status changed from reopened to assigned

#5 @johnjamesjacoby
10 years ago

  • Milestone changed from Future Release to 1.2.1

It's a little complicated but it's a good patch for 1.2.1.

All the filter_kses and stripslashes calls were retained in the patch.

r2719 still doesn't let those values get filtered correctly, and the variables in the sprintf's can't be rearranged as it sits now.

#6 @DJPaul
9 years ago

  • Component set to Core
  • Keywords has-patch needs-testing removed

I've started work looking at these again for a patch for 1.3

#7 @paulhastings0
9 years ago

  • Summary changed from Patch for fix for r2697 to [patch] Patch for fix for r2697

#8 @boonebgorges
9 years ago

  • Milestone changed from 1.3 to 1.4

Bumping to 1.4 unless there is a patch out there that I don't know about.

#9 @boonebgorges
8 years ago

  • Severity set to normal

DJPaul, I know you are still interested in revising BP emails, maybe building a proper API/templating system for them. Does that fall under this ticket?

#10 @boonebgorges
8 years ago

  • Summary changed from [patch] Patch for fix for r2697 to Refactor notification emails

#11 @DJPaul
8 years ago

  • Milestone changed from 1.6 to Future Release

Yes, still keen. Bumping because not sure I have enough time to commit to a patch for 1.6. If anyone else wants to work on this, get in contact and I'll share my ideas :)

#12 @boonebgorges
5 years ago

r-a-y and I have been working on a top-secret project to refactor the way that emails work (sending HTML alongside plaintext). Maybe we can use this ticket for tracking that project.

#13 @johnjamesjacoby
5 years ago

Sounds perfect. A more robust email class has been on our minds for a while.

#14 @DJPaul
4 years ago

  • Milestone Future Release deleted
  • Status changed from assigned to closed

Going to close this fond old ticket in favour of #6592. Everything here will be taken into account, just trying to consolidate duplicate tickets a bit.

Note: See TracTickets for help on using tickets.