Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 15 years ago

#1905 closed defect (bug) (fixed)

slash in @mention email

Reported by: intimez's profile intimez Owned by:
Milestone: 1.2 Priority: major
Severity: Version:
Component: Keywords: @mention, mention has-patch
Cc:

Description

user post @mention with words that include apostrophe and the email shows slash

example:
@guest what's it's won't

email will show
"@guest what\'s it\'s won\'t"

Attachments (2)

1905.001.diff​ (1.3 KB) - added by cnorris23 15 years ago.
1905.002.diff​ (5.7 KB) - added by cnorris23 15 years ago.
Don't strip slashes twice

Download all attachments as: .zip

Change History (6)

#1 @cnorris23
15 years ago

Patch attached. Replaced function stripslashes_deep with stripslashes, as it wasn't stripping the slashes. Also, removed the wp_filter_kses() function from the $group->name variable, as it was adding the slashes back after being stripped.

@cnorris23
15 years ago

#2 @cnorris23
15 years ago

  • Keywords has-patch added
  • Milestone set to 1.2

When calling $group = new BP_Groups_Group the 'name' key has stripslashes applied before it's added to the $group array, so there's no need to apply stripslashes again in bp-groups-notifications.php.

@cnorris23
15 years ago

Don't strip slashes twice

#3 @DJPaul
15 years ago

I think we need wp_filter_kses on this

#4 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2663]) Fixes #1905

Note: See TracTickets for help on using tickets.