Make it possible to favorite activity items from the source content (blog post, forum post, etc)

[snark]

I am running a fresh installation of BP 1.2-RC2 for WP 2.9.1 single user. I have noticed that a logged-in a user can click a "Favorite" button next to a post in the site-wide or Group Activity streams and add that post to their list of favorites. However, the Favorite button does not appear in the Forum view, even for the same post that it does appear next to in the Activity stream(s).

So if you were reading posts in the Forum view, and you wanted to mark one as a favorite, you'd have to click over to an Activity stream, find the post, click "Favorite", then go back to where you were reading in the Forum. The "Favorite" button should appear in all locations.

[windhamdavid]

this is a great recommendation, but it would be more appropriately tagged an enhancement for a future release.

[snark]

Ok... It just seems like something broken at this point, is all, since the same content can be tagged a favorite in one place (Activity stream) but not in the place it originates (Forum). But hey, I know you guys are busy, and you really are doing a great job with this, so no worries.

[cnorris23]

@snark
I agree with you that this is an inconsistency, and therefore a bug. However, looking at the code (I only glanced), it looks like some functions might have to be reworked to get this going. It could be made to work with existing functions, but right now, they're pretty much meant to only favorite things from activity streams. Given that, I also agree with windhamdavid that this is more of an enhancement. This might not even happen for 1.2.1, and might be something that shows up in 1.3 instead. You can try a plugin by John James Jacoby, ​BP Favorites. It looks like it might do what you're requesting for the interim, although I've not tested it.

[boonebgorges]

From BP's point of view, the forum post and the corresponding activity item are *not* the same content. Not necessarily intuitive from a user's point of view, but that explains why it is the way that it is.

One possible fix is to save all Favorites data for forum posts (and blog posts, and blog comments...) as Activity favorites data. So when you favorite a forum post, you're *really* favoriting the corresponding activity item. That'd make for easy implementation. The only problem would be if the author of the post (or site admin) decided to delete the activity item (or block it from being created in the first place) without also deleting the original content. Then you'd lose your favorite status even though the content was still there.

I don't know that there will be time to implement this by 1.3, so I'm bumping it to 1.4. Feedback or patches welcome.

[boonebgorges]

The idea of adding 'favorite' buttons everywhere, that refer back to corresponding activity items, strikes me as kind of a mess. If we ever decide to rebuild the 'favorites' feature, I think it should be generalized in this way; otherwise, this is pretty clearly plugin territory.

[slaFFik]

Closing this ticket in favour of #5610