Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 15 years ago

#1818 closed defect (bug) (fixed)

AJAX query string filtering - empty qs not being filtered HAS-PATCH

Reported by: mrmaz's profile MrMaz Owned by:
Milestone: 1.2 Priority: major
Severity: Version:
Component: Keywords: has-patch
Cc:

Description

In bp_dtheme_ajax_querystring() in ajax.php the query string is not being passed through the filter if it is empty. I have situations where it is critical that I be able to do this. One example is being able to inject a 'primary_id' into the query string. If the query string happens to be empty, then my filter is bypassed.

I don't think there could possibly be an issue where passing an empty string would harm any of the loop templates. I have tested this patch on 1.2-RC and did not have any problems.

Attachments (1)

empty_querystring_not_filtered.diff (1013 bytes) - added by MrMaz 15 years ago.
patch for bp-themes/bp-default/_inc/ajax.php

Download all attachments as: .zip

Change History (2)

@MrMaz
15 years ago

patch for bp-themes/bp-default/_inc/ajax.php

#1 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2606]) Fixes #1818

Note: See TracTickets for help on using tickets.