Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#1799 closed defect (bug) (fixed)

Profile - Edit(HAS PATCH)

Reported by: ezd's profile Ezd Owned by:
Milestone: 1.2 Priority: minor
Severity: Version:
Component: Keywords: needs-testing has-patch
Cc: DennisSmolek

Description

When you edit your profile and you don't fill out all the "required" fields you get a red bar notification. This bar is being overlayed by your profile picture, see attached screenshot.

Also, it's hard to see what boxes is required and which isn't. Maybe these textfields should be marked with a * and a text saying required?

Attachments (5)

Profile - edit.png (83.3 KB) - added by Ezd 13 years ago.
IE.jpg (155.5 KB) - added by Ezd 13 years ago.
New screenshot from IE
Profile - Change Avatar.png (83.8 KB) - added by Ezd 13 years ago.
bpcss.png (91.8 KB) - added by DennisSmolek 13 years ago.
firebug showing css and fix
default.diff (172 bytes) - added by windhamdavid 13 years ago.
_inc/css/default.css

Download all attachments as: .zip

Change History (13)

@Ezd
13 years ago

#1 @apeatling
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2584]) Fixes #1799

#2 @Ezd
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

It looks like there's still a problem here. Tested with IE this time. See attached screenshot.

@Ezd
13 years ago

New screenshot from IE

#3 @Ezd
13 years ago

Its not just in Profile - Edit. Same issue in Profile - Change Avatar page. Please see new attached screenshot.

#4 @DennisSmolek
13 years ago

This seems like a Z index issue in the CSS for the image and the alert bar. adding something like:
z-index: 1000;

should fix it and make (most) stuff go under the bar..

#5 @DennisSmolek
13 years ago

  • Cc DennisSmolek added
  • Summary changed from Profile - Edit to Profile - Edit(HAS PATCH)

Ok I was wrong, but to fix this do this:
Edit default.css in wpcontent/plugins/buddypress/bp-themes/bp-default/_inc/css/default.css

Line 620

div#message.error p {

background: #e41717;
color: #fff;
border-color: #a71a1a;
clear:both;

}

because all the other elements are floating(including the avatar) they float over each other based upon hierarchy in the parent DIV regardless of z-index. Adding clear:left; or clear:both; fixes this.. uploading image to confirm

@DennisSmolek
13 years ago

firebug showing css and fix

#6 @DennisSmolek
13 years ago

  • Keywords needs-testing added

#7 @windhamdavid
13 years ago

  • Keywords has-patch added

i dbl checked in IE and all of the other #message.error's in ajax.php and this patch appears to correct the IE issue and not affect any others.

@windhamdavid
13 years ago

_inc/css/default.css

#8 @apeatling
13 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [2623]) Fixes #1799 props windhamdavid

Note: See TracTickets for help on using tickets.