Skip to:

Opened 14 years ago

Closed 14 years ago

#1793 closed defect (bug) (fixed)

Move theme content cookies from core to theme HAS-PATCH

Reported by: mrmaz's profile MrMaz Owned by: apeatling's profile apeatling
Milestone: 1.2 Priority: major
Severity: Version:
Component: Keywords: has-patch


This patch moves the groups, members, forums, and blogs theme dependent cookies out of core and into the default theme.

Activity cookies are still in core, but some forward compatibility has been put in place.

Attachments (4)

move_theme_content_cookies_to_ajax.patch (13.6 KB) - added by MrMaz 14 years ago.
move_all_theme_cookies_to_ajax.patch (24.8 KB) - added by MrMaz 14 years ago.
move_theme_cookies.diff (23.6 KB) - added by MrMaz 14 years ago.
diffed this directly with svn
remove_cookies_apeatling.diff (39.4 KB) - added by apeatling 14 years ago.

Download all attachments as: .zip

Change History (8)

#1 @MrMaz
14 years ago

About to attach a patch that moves ALL cookies to the theme so ignore the first patch.

14 years ago

diffed this directly with svn

#2 @apeatling
14 years ago

  • Type changed from enhancement to defect

Here's the patch I've worked on based on the changes from MrMaz. It keeps all of the parameter logic inside the actual template tags so any other theme can still function correctly if they pass no parameters to the loops. There is no actual creation of the primary querystring in the theme - all we are doing is overriding parameters based on cookie values that are set.

You can filter the parameters that are overridden in the template by using this filter:

apply_filters( 'bp_dtheme_ajax_querystring', $querystring, $object, $filter, $scope, $page, $search_terms, $extras );

#3 @apeatling
14 years ago

I'm going to commit this since I need to get this in for the RC and it needs testing. We can tweak/change filters etc as we go.

#4 @apeatling
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2580]) Fixes #1793 - remove querystring building from theme and querystring cookie management from core.

Note: See TracTickets for help on using tickets.