Skip to:
Content

BuddyPress.org

Opened 15 years ago

Closed 14 years ago

#1757 closed defect (bug) (fixed)

"Load more" when no more

Reported by: ezd's profile Ezd Owned by:
Milestone: 1.5 Priority: minor
Severity: Version:
Component: Core Keywords:
Cc:

Description

In your profile you have a "Load more" button even through there's no more content. When you click it it just says "Sorry, there was no activity found. Please try a different filter.".

Andy fixed this for groups earlier, not knowing if it's broken too. But "Load more" should only be there if there's more content.

Attachments (2)

1757.1.diff​ (1.3 KB) - added by boonebgorges 14 years ago.
1757.2.diff​ (1.3 KB) - added by boonebgorges 14 years ago.

Download all attachments as: .zip

Change History (6)

#1 @apeatling
15 years ago

  • Milestone changed from 1.2 to 1.3
  • Priority changed from major to minor

This will *only* happen if the total number of updates is more or exactly equal to the per page value. Otherwise the load more button will not show. This is the most efficient way of dealing with this without pre-querying for the total number. I will look into this more for 1.3, but for now I think it's fine.

#2 @boonebgorges
14 years ago

  • Component set to Core

Can anyone double check the logic of the solution in 1757.1.diff?

@boonebgorges
14 years ago

#3 @boonebgorges
14 years ago

Oops, I found an error myself. See 1757.2.diff instead.

@boonebgorges
14 years ago

#4 @boonebgorges
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [3670]) Corrects logic for showing 'Load More' link on activity loop. Fixes #1757

Note: See TracTickets for help on using tickets.