Skip to:
Content

Opened 9 years ago

Closed 5 years ago

#1745 closed defect (bug) (no action required)

Make general settings behave like component setup, with enabled/disabled radio buttons has-patch

Reported by: andrew_s1 Owned by:
Milestone: Priority: minor
Severity: normal Version:
Component: Core Keywords: needs-refresh
Cc: wordpress@…

Description

The General Settings screen, with its double negatives ("Disable this function: Yes/No"), is confusing, and is inconsistent with the component setup screen ("function: enabled / disabled).

The attached patch removes the double-negatives ("No, don't disable"), and makes the general settings screen consistent with the component setup screen

Attachments (1)

bpcoreadminsettings.diff (8.3 KB) - added by andrew_s1 9 years ago.
patch to make general settings screen more ergonomic

Download all attachments as: .zip

Change History (12)

@andrew_s1
9 years ago

patch to make general settings screen more ergonomic

#1 @andrew_s1
9 years ago

  • Cc wordpress@… added
  • Keywords has-patch added

#2 @apeatling
9 years ago

  • Milestone changed from 1.2 to 1.3

Punting this to the next version, this will break checks for these settings.

#3 @andrew_s1
9 years ago

sorry - my bad - if I'd known there was a test-rig, I'd have had a go at patching that too. Where can I find it?

#4 @paulhastings0
8 years ago

  • Component set to Core
  • Summary changed from make general settings behave like component setup, with enabled/disabled radio buttons has-patch to [patch] make general settings behave like component setup, with enabled/disabled radio buttons has-patch

#5 @DJPaul
8 years ago

  • Keywords needs-patch added; has-patch removed
  • Summary changed from [patch] make general settings behave like component setup, with enabled/disabled radio buttons has-patch to Make general settings behave like component setup, with enabled/disabled radio buttons has-patch

We'd also need a patch to change all of the checks throughout BuddyPress to accomodate this change.

#6 @boonebgorges
8 years ago

  • Milestone changed from 1.3 to Future Release

andrew_s1, are you out there? I like this idea but it won't make it into 1.3 unless someone provides a thorough patch.

#7 @andrew_s1
8 years ago

I've no idea what checks are being talked about. So I can't write a patch to fix those checks.

#8 @boonebgorges
8 years ago

andrew_s1 - Sadly there is no test rig.

I think the original concern was that by changing positives to negatives, BP would have to be modified in every place where it checks the settings so that it looks for true rather than false. But as I look at the patch it looks like you have kept the same values in the database, so maybe the concern is ungrounded.

#9 @andrew_s1
8 years ago

boonbgorges: you're right, the only thing that the patch changes is the screen viewed by the user: the meaning of the settings values themselves doesn't change.

I did it this way, sacrificing a bit of clarity on the source-code side, in the interests of better user experience, and simplicity of patch.

#10 @boonebgorges
8 years ago

  • Keywords needs-refresh added; needs-patch removed

OK, that makes good sense. Unfortunately, the patch has gone stale, because of the way that bp-core/admin/bp-core-admin.php has been reworked on the trunk. If you wouldn't mind refreshing the patch against the trunk, I can put it in.

#11 @boonebgorges
5 years ago

  • Milestone Future Release deleted
  • Resolution set to invalid
  • Severity set to normal
  • Status changed from new to closed

It looks like something very close to this change has already been made. (I can't find the ticket or changeset.)

Note: See TracTickets for help on using tickets.