Missing filter on template check inside bp_core_catch_no_access HAS-PATCH

[MrMaz]

In 1.2 a condition was added to bp_core_catch_no_access to look for the template and redirect to home, but the bp_located_template filter is not being applied there like it is in bp_core_catch_uri.

Since bp_core_catch_no_access runs before bp_core_catch_uri, it is impossible to reach the filtered check.

I am attaching a patch that I tested.

[MrMaz]

patch for bp-core-catchuri.php

[rvenable]

Nice. I noticed this bug breaking my plugin yesterday but didn't have a chance to report it, so you beat me to it MrMaz!

I noticed that the offending code was added in changeset:2088, for what its worth.

I think one problem with the code that in r2088 is that it uses $bp_path differently than $bp_path is used in the bp_core_catch_uri() function. bp_core_catch_no_access() just appends '.php' to the end of $bp_path and trying to locate the template. bp_core_catch_uri() does a little more by first treating $bp_path as an array (which doesn't seem to really do anything, but might break things later), then trying to locate the template but applying filters onto the result (the crucial part for plugins).

So, I think there should be a consistent way of handling $bp_path. You can make a function bp_located_template() which handles the locating. That function can return the located path, or an empty string if the path wasn't found, and a filter can be applied on its return value.

function bp_located_template() {
	/* Can be a single template or an array of templates */
	$templates = $bp_path;

	foreach ( (array)$templates as $template )
		$filtered_templates[] = $template . '.php';

	return apply_filters( 'bp_located_template', locate_template( (array) $filtered_templates, false ), $filtered_templates ) ;
}

Or better yet, just do everything in bp_catch_uri() and save it as a global $bp_located_template instead of $bp_path.

[MrMaz]

I really like rvenable's solution, although I haven't tested yet. It makes a lot of sense to refactor this into one function now.

Btw, $bp_path needs to be globalized.

[apeatling]

(In [2489]) Fixes #1733 props MrMaz

[MrMaz]

I just ran into the problem that rvenable describes above. It didn't hit me at first, but now I understand the issue. bp_core_catch_uri sends an array to the bp_located_template filter, so the bp_core_catch_no_access should also be sending an array. MY BAD!

Will be attaching a patch to fix this.

[apeatling]

(In [2525]) Fixes #1733