Skip to:
Content

BuddyPress.org

Opened 14 years ago

Closed 14 years ago

#1674 closed defect (bug) (fixed)

CSS Focus styles not defined

Reported by: djpaul's profile DJPaul Owned by:
Milestone: 1.2 Priority: minor
Severity: Version:
Component: Keywords: usability, css, has-patch
Cc:

Description

I've milestone this for 1.2 as the fix is simple and has a fairly important usability impact for people who use the keyboard as the main means of navigating a site.

If you try to navigate around http://testbp.org/ using the tab button, you've got no way of seeing which element you currently have "selected".

This is because bp-default uses Eric Meyer's reset.css which has the following section. I have had a quick test removing this (and leaving it to browsers' defaults) and visually it looks fine. My recommendation would be to just remove these lines from reset.css.

/* remember to define focus styles! */
:focus {
	outline: 0;
}

Attachments (1)

ticket-1674.patch (422 bytes) - added by DJPaul 14 years ago.

Download all attachments as: .zip

Change History (5)

#1 @DJPaul
14 years ago

  • Keywords has-patch added

@DJPaul
14 years ago

#2 @apeatling
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2513]) Fixes #1674

#3 @DJPaul
14 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

I feel the changes made are insufficient. For example, when I tab between the main menu nav in the header, I can't visually see which menu item is selected.

#4 @apeatling
14 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

I don't really want them to show on the tabs otherwise whenever you click one it looks like junk. I think this is something you should add in your child theme if you want it.

Note: See TracTickets for help on using tickets.