Skip to:
Content

Opened 9 years ago

Closed 9 years ago

#1620 closed defect (bug) (fixed)

bp_create_excerpt issue with external images for activity stream...

Reported by: grimbog Owned by:
Milestone: 1.2 Priority: major
Severity: Version:
Component: Keywords: bp_create_excerpt, images, external, activity
Cc:

Description

issue has been detected where users are placing in large (greater than 800px width) images from an external site using media upload with urls. The activity stream displays these external images without being scaled down, so bleed over to the 2nd column.

I've done a quick add_filter that simply strips out img tags for now, but suggest maybe having a scaler that simply sizes it down to within the main column width. Or maybe even filter out external site images altogether?

This brings a further issue - I'm getting users who are placing in a list of images on their blogs like so:

<img src="mysite.com/image1.jpg">
<img src="mysite.com/image2.jpg">
<img src="mysite.com/image3.jpg">
<img src="mysite.com/image4.jpg">

...which causes bp_create_excerpt to display them all because the word count doesn't exceed 55. Doesn't look nice on the stream, so I've stripped them out as described above via add_filter.

Change History (4)

#1 @grimbog
9 years ago

  • Keywords bp_create_excerpt images external activity added
  • Milestone set to 1.2

#2 in reply to: ↑ description @grimbog
9 years ago

Replying to grimbog:

Additional thought on this - might be an idea to do as facebook for blog posts containing images e.g. grab one thumbnail to represent the blog post (rather than display multiple images).

...So it searches the content of the blog post for images, if one is found then process it as a thumbnail and align text next to it.

#3 @apeatling
9 years ago

@grimbog: I like this solution.

#4 @apeatling
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [2383]) Auto thumbnail the first image in a blog post and display it on the activity stream. This stops huge images in blogs posts from displaying on the stream and messing with the design. Fixes #1620

Note: See TracTickets for help on using tickets.