Opened 15 years ago
Closed 13 years ago
#1307 closed enhancement (fixed)
Add support for "current_theme_supports"
Reported by: | GIGALinux | Owned by: | |
---|---|---|---|
Milestone: | 1.6 | Priority: | minor |
Severity: | normal | Version: | |
Component: | Core | Keywords: | |
Cc: | GIGALinux |
Description
This patch adds support for the function current_theme_supports which is introdruced with WordPress 2.9. The user gets a warning if the current theme used is maybe incompatible with BuddyPress. The user gets the possibility to dismiss the message.
Attachments (1)
Change History (16)
#3
@
15 years ago
This is working for me.
BTW, this code is beautifully written.
A compliment like this doesn't come often if ever from me.
#5
@
15 years ago
Thanks for testing and the compliment, but thats only the WordPress coding standards ;-)
http://codex.wordpress.org/WordPress_Coding_Standards
#8
@
15 years ago
- Milestone changed from 1.2 to 1.2.1
I thought something like this was in 1.2 but I can't find it quickly. Bumping to 1.2.1 for further review.
#9
@
15 years ago
We ought to use this instead of the technique used in bp_core_activation_notice(). We can set it in bp-default and hopefully child themes will inherit it.
#10
@
14 years ago
- Component set to Core
- Summary changed from Add support for "current_theme_supports" to [patch] Add support for "current_theme_supports"
#13
@
14 years ago
- Keywords has-patch tested dev-feedback removed
- Milestone changed from 1.3 to Awaiting Review
- Owner DJPaul deleted
- Summary changed from [patch] Add support for "current_theme_supports" to Add support for "current_theme_supports"
The idea of switching the theme nag to current_theme_supports() is an interesting one; what else could BP do if it checked for support?
However, the approach in this patch is unsuitable as it would add (yet another) option to the blog options table, which is why BP check if a constant is set in the current implementation.. We need to be consolidating these, not adding more.
Going to try and test this tonight