Skip to:
Content

Opened 9 years ago

Closed 7 years ago

#1307 closed enhancement (fixed)

Add support for "current_theme_supports"

Reported by: GIGALinux Owned by:
Milestone: 1.6 Priority: minor
Severity: normal Version:
Component: Core Keywords:
Cc: GIGALinux

Description

This patch adds support for the function current_theme_supports which is introdruced with WordPress 2.9. The user gets a warning if the current theme used is maybe incompatible with BuddyPress. The user gets the possibility to dismiss the message.

Attachments (1)

current_theme_supports.patch (2.3 KB) - added by GIGALinux 9 years ago.

Download all attachments as: .zip

Change History (16)

#1 @DJPaul
9 years ago

  • Keywords needs-testing added

#2 @jason_jm
9 years ago

Going to try and test this tonight

#3 @jason_jm
9 years ago

This is working for me.

BTW, this code is beautifully written.

A compliment like this doesn't come often if ever from me.

#4 @jason_jm
9 years ago

  • Keywords tested added; needs-testing removed

This is working for me = tested

#5 @GIGALinux
9 years ago

Thanks for testing and the compliment, but thats only the WordPress coding standards ;-)
http://codex.wordpress.org/WordPress_Coding_Standards

#6 @jason_jm
9 years ago

Yup! And code is poetry :-D

#7 @apeatling
9 years ago

  • Milestone changed from 1.1.3 to 1.2

#8 @DJPaul
9 years ago

  • Milestone changed from 1.2 to 1.2.1

I thought something like this was in 1.2 but I can't find it quickly. Bumping to 1.2.1 for further review.

#9 @DJPaul
9 years ago

We ought to use this instead of the technique used in bp_core_activation_notice(). We can set it in bp-default and hopefully child themes will inherit it.

#10 @paulhastings0
8 years ago

  • Component set to Core
  • Summary changed from Add support for "current_theme_supports" to [patch] Add support for "current_theme_supports"

#11 @DJPaul
8 years ago

  • Keywords dev-feedback added

Feedback appreciated if we want to do this?

#12 @DJPaul
8 years ago

  • Owner changed from apeatling to DJPaul
  • Status changed from new to assigned

#13 @DJPaul
8 years ago

  • Keywords has-patch tested dev-feedback removed
  • Milestone changed from 1.3 to Awaiting Review
  • Owner DJPaul deleted
  • Summary changed from [patch] Add support for "current_theme_supports" to Add support for "current_theme_supports"

The idea of switching the theme nag to current_theme_supports() is an interesting one; what else could BP do if it checked for support?

However, the approach in this patch is unsuitable as it would add (yet another) option to the blog options table, which is why BP check if a constant is set in the current implementation.. We need to be consolidating these, not adding more.

#14 @DJPaul
8 years ago

  • Milestone changed from Awaiting Review to Future Release

#15 @DJPaul
7 years ago

  • Milestone changed from Future Release to 1.6
  • Resolution set to fixed
  • Severity set to normal
  • Status changed from assigned to closed

Marking this as resolved as it was implemented with recent commits r5747 and r5749

Note: See TracTickets for help on using tickets.