Skip to:
Content

Opened 9 years ago

Closed 9 years ago

#1305 closed defect (bug) (fixed)

Problems with Content filter added to bp_get_activity_content()

Reported by: uglyrobot Owned by:
Milestone: 1.1.3 Priority: major
Severity: Version:
Component: Keywords:
Cc: pavelevap, MrMaz

Description

In 1.1.x in the bp_get_activity_content() function of bp-activity-templatetags.php, a filter for the content was added. Line 255:

/* Add 'the_content' filter to activity to allow existing plugins to replace text as they would on post text. (extra smilies etc) */
$content = apply_filters( 'the_content', $content );

Now all my plugins that use that filter for blog posts are adding their html to the site wide activity widgets and breaking them.

Change History (5)

#1 @pavelevap
9 years ago

  • Cc pavelevap added

I have the same problem here: http://trac.buddypress.org/ticket/1133

#2 follow-up: @MrMaz
9 years ago

  • Cc MrMaz added

I think this filter should be renamed. There is no way to make the activity component work with all of the wordpress plugins that also use this hook.

Suggested fix is to rename the hook and if people really want their blog plugins to affect the activity component output, they can manually apply the hooks in their functions.php

#3 @pavelevap
9 years ago

There should be also the way to repair broken widget, because inserted HTML is still here...

#4 in reply to: ↑ 2 @uglyrobot
9 years ago

  • Priority changed from minor to major

Replying to MrMaz:

I think this filter should be renamed. There is no way to make the activity component work with all of the wordpress plugins that also use this hook.

Suggested fix is to rename the hook and if people really want their blog plugins to affect the activity component output, they can manually apply the hooks in their functions.php

I agree. Just rename the filter. It should be something like 'bp_activity_content'.

#5 @apeatling
9 years ago

  • Resolution set to fixed
  • Status changed from new to closed

This has been removed in the 1.1 branch.

Note: See TracTickets for help on using tickets.