Skip to:
Content

BuddyPress.org

Opened 17 years ago

Closed 15 years ago

#1299 closed enhancement (fixed)

site wide activity widget should aware "rel" tag

Reported by: levinng Owned by: masonjames
Priority: minor Milestone: 1.5
Component: Activity Version:
Severity: Keywords: has-patch
Cc:

Description

I'd like to suggest site wide activity widget should allow "rel" tag for images,
it'll open up for image display plugin to work properly, such as lightbox or thickbox.

Attachments (1)

reltag.diff​ (568 bytes ) - added by masonjames 15 years ago.
Added 'rel' attribute to the activity filter

Download all attachments as: .zip

Change History (10)

#1 @apeatling
17 years ago

  • Milestone → 1.2
  • Type enhancement → defect

Will add support for this in 1.2.

#2 @apeatling
17 years ago

  • Keywords needs-patch added

Need a patch for this.

#3 @apeatling
17 years ago

  • Milestone 1.2 → 1.2.1
  • Type defect → enhancement

Bumping to 1.2.1.

#4 @boonebgorges
16 years ago

  • Component → Core
  • Milestone 1.3 → 1.4

There is no sitewide activity widget in BP anymore, though I assume the issue is more broadly relevant.

Punting to 1.4 in the absence of a patch. If anyone wants to step up, please feel free to bump this back to 1.3.

#5 @DJPaul
16 years ago

I assume this would just involve adding the rel tag to the bp_activity_filter_kses() filter? Easy props for someone if they would like to patch it.

#6 @masonjames
15 years ago

  • Owner set to masonjames
  • Status new → accepted

@masonjames
15 years ago

Added 'rel' attribute to the activity filter

#7 @masonjames
15 years ago

  • Keywords has-patch added; needs-patch removed
  • Resolution → fixed
  • Status accepted → closed

Here's my first patch. Feel free to let me know if I've done it incorrectly :)

#8 @boonebgorges
15 years ago

  • Component Core → Activity
  • Milestone 1.4 → 1.3
  • Priority major → minor
  • Resolution fixed
  • Status closed → reopened

Thanks for the patch, I'll have a look shortly.

#9 @boonebgorges
15 years ago

  • Resolution → fixed
  • Status reopened → closed

Looks like this is already done in the trunk, as of r3494.

Note: See TracTickets for help on using tickets.