Skip to:

Opened 15 years ago

Closed 15 years ago

#1289 closed defect (bug) (fixed)

All activity feeds have wrong XML <link> tag data for new friendship announcements

Reported by: mrmaz's profile MrMaz Owned by: mrmaz's profile MrMaz
Milestone: 1.1.3 Priority: minor
Severity: Version:
Component: Keywords: has-patch activity rss friend friendship link xml url href
Cc: MrMaz


Here is where the activity feed templates are calling the template tag:

The problem is that when the bp_activity_feed_item_link() function returns the "primary_link" field (for a new friendship activity item) in the activity feed templates, an <a> tag is put into the XML <link> tag, which results in bad behavior by feed readers.

The problem is with the function friends_accept_friendship() on this line. It calls bp_core_get_userlink() which returns an <a> tag instead of just the URL. The entire tag is then stored in the table's "primary_link" field. I don't think this is correct, unless I missed something.

Suggested fix is to change line 632 to use bp_core_get_userurl() instead which returns only the URL.

Attachments (1)

1289.patch (1.1 KB) - added by MrMaz 15 years ago.

Download all attachments as: .zip

Change History (5)

15 years ago

#1 @MrMaz
15 years ago

  • Cc MrMaz added
  • Keywords has_patch added
  • Milestone set to 1.1.3
  • Owner set to MrMaz
  • Status changed from new to accepted

Need someone else to test this patch to make sure it doesn't break anything.

#2 @MrMaz
15 years ago

  • Keywords has-patch added; has_patch removed

#3 @apeatling
15 years ago

Needs testing.

#4 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

(In [2117]) Fixes #1289 props MrMaz

Note: See TracTickets for help on using tickets.