Skip to:
Content

BuddyPress.org

Opened 12 years ago

Closed 12 years ago

#1260 closed defect (bug) (fixed)

bp_user_fullname and bp_displayed_user_fullname are inside out

Reported by: CyberSliver Owned by:
Milestone: 1.2 Priority: minor
Severity: Version:
Component: Keywords: templatetags, has-patch
Cc:

Description

Current trunk has:

1205    function bp_user_fullname() {
1206            global $bp;
1207            echo apply_filters( 'bp_user_fullname', $bp->displayed_user->fullname );
1208    }
1209            function bp_displayed_user_fullname() {
1210                    return bp_user_fullname();
1211            }

bp_user_fullname echoes as expected, but bp_displayed_user_fullname will return nothing.
This should of course be:

1205    function bp_user_fullname() {
1206            echo bp_displayed_user_fullname();
1207    }
1208            function bp_displayed_user_fullname() {
1209                    global $bp;
1210                    return apply_filters( 'bp_user_fullname', $bp->displayed_user->fullname );
1211            }

For consistency, shouldn't they be called bp_displayed_user_fullname and bp_get_displayed_user_fullname?

Change History (3)

#1 @DJPaul
12 years ago

  • Keywords has-patch added

#2 @apeatling
12 years ago

  • Milestone set to 1.2

#3 @apeatling
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in trunk.

Note: See TracTickets for help on using tickets.