Skip to:
Content

Opened 9 years ago

Closed 9 years ago

#1230 closed defect (bug) (no action required)

Groups Paginated Wire List hrefs may be wrong, and not work correctly.

Reported by: valilenk Owned by: boonebgorges
Milestone: 1.2 Priority: minor
Severity: Version:
Component: Keywords: Group Wire, Paginated Href Links, has-patch, needs-testing
Cc: boonebgorges, Jason_JM

Description

In groups pagination links looks like that: "http:/?wpage=2"

In profiles it's fine: "http://site/members/nickname/?wpage=2"

Attachments (1)

group-wire-pagination-link.patch (1.0 KB) - added by boonebgorges 9 years ago.

Download all attachments as: .zip

Change History (15)

#1 @boonebgorges
9 years ago

  • Cc boonebgorges added
  • Keywords has-patch added
  • Owner set to boonebgorges
  • Status changed from new to accepted

#2 @boonebgorges
9 years ago

  • Status changed from accepted to assigned

#3 @DJPaul
9 years ago

  • Keywords needs-testing added

#4 @Jason_JM
9 years ago

  • Cc Jason_JM added
  • Summary changed from In groups next-wire-page link is wrong to Groups Paginated Wire List hrefs may be wrong, and not work correctly.

I don't have errors with this though I think it may have to do with rewrite rules.

I'm using NginX (as is buddypress.org I believe), your mileage may vary.

Stock implementation (without using the supplied patch) works fine on my end.

#5 @Jason_JM
9 years ago

  • Keywords Group Wire Paginated Href Links added

#6 @Jason_JM
9 years ago

  • Priority changed from major to minor

Flagged minor for now, we need more info.

#7 @boonebgorges
9 years ago

Weird that you don't see the problem, Jason_JM. I was definitely experiencing it without the patch. The version of bp_wire_posts_template in trunk builds the pagination URLs using $bp->displayed_user->domain, which is null for group pages, and even if it weren't null it wouldn't make for the right URL.

#8 @Jason_JM
9 years ago

I'm with you, it's wierd. There is no way i'm down playing this ticket though. Just need more info and I'd like for the rest of the developers to chime in too.

Now, I use nginx i probably have a re-write for it. I have to check tonight.

The buddypress.org home uses nginx too I believe (as does wordpress.com) and you can see that the URLs there are working. This was the first thing I checked. I agree with you however, that the testbp site is not working. I confirm that for sure.

But check out the org page: http://buddypress.org/groups/bp-events/wire/

#9 @jason_jm
9 years ago

I need some server info, going to hit up Barry.

#10 @jason_jm
9 years ago

Got the word.
buddypress.org uses lightspeed
testbp.org uses apache.

Weird indeed...

#11 @johnjamesjacoby
9 years ago

Because the wire can be "inherited" by other plugins, it will need to be smarter than just looking at profiles and blogs. The events and album plugins are good examples.

The included patch will fix the current core but isn't future proof quite yet.

#12 @jason_jm
9 years ago

  • Milestone changed from 1.2 to 1.1.3

Going to try and test this tonight

#13 @apeatling
9 years ago

  • Milestone changed from 1.1.3 to 1.2

#14 @apeatling
9 years ago

  • Resolution set to invalid
  • Status changed from assigned to closed

Not valid anymore in trunk and 1.2

Note: See TracTickets for help on using tickets.