Skip to:
Content

Opened 5 years ago

Closed 4 years ago

#1226 closed defect (bug) (fixed)

private blog posts show up in site wide activity

Reported by: belogical Owned by: johnjamesjacoby
Milestone: 1.1.2 Priority: major
Severity: Version:
Component: Keywords: private blogs, new post, site wide activity, needs-patch
Cc:

Description

private blog posts show up in site wide activity. verified on testbp.org

http://testbp.org/members/belogical/

Change History (7)

comment:1 johnjamesjacoby5 years ago

If it's private, why can I still view the original blog post in the first place?

comment:2 DJPaul4 years ago

  • Keywords needs-patch added
  • Priority changed from critical to major

"Privacy: I would like my blog to appear in search engines like Google and Technorati, and in public listings around this site."

Confirmed.

comment:3 johnjamesjacoby4 years ago

  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

I have two potential fixes for this, but they perform differently.

  1. Private blog post will not appear in activity feed nor in user/blogs/recent-posts/
  1. Private blog post will not appear in activity feed, but user/blogs/recent-posts/ will show private blog posts.
Option number 2 can be balanced out to hide the blog posts if !bp_is_home()
!is_site_admin() separately. I think #2 is the best option myself but will take a little longer to patch and test.

Thoughts?

comment:4 johnjamesjacoby4 years ago

Option 3 would be to stop the activity recording for all blog activity if the blog_public is 0, and handle the posts and comments in their respective functions.

I think this is the way I'm going to patch this.

comment:5 DJPaul4 years ago

Agreed w/ Option 3. Bear in mind blog comments too. Might be worth hooking up with Jeff Sayre to see if/how his privacy component may/may not affect this.

comment:6 apeatling4 years ago

This is a new bug, it was working before so it's a matter of finding out what went wrong somewhere.

comment:7 apeatling4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2054]) Fixes #1226

Note: See TracTickets for help on using tickets.