Skip to:

Opened 15 years ago

Closed 15 years ago

#1221 closed defect (bug) (fixed)

xprofile xprofile_insert_field - description arg wrong

Reported by: djpaul's profile DJPaul Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.2 Priority: minor
Severity: Version:
Component: Keywords: xprofile, has-patch



line 832 needs to be
$field->desc = $description;

and not
$field->description = $description;

Attachments (1)

rename-desc-to-description.patch (6.1 KB) - added by johnjamesjacoby 15 years ago.
xprofile desc to description

Download all attachments as: .zip

Change History (5)

#1 @johnjamesjacoby
15 years ago

  • Keywords has-patch added
  • Owner set to johnjamesjacoby
  • Status changed from new to assigned

Renaming everything else the other way around makes more sense because it brings it in line with the database table column named 'description' and also bp-groups, which uses ->description.

15 years ago

xprofile desc to description

#2 @DJPaul
15 years ago

Indeed but didn't have time to patch it so just reported the minimum.

#3 @johnjamesjacoby
15 years ago

Was a good catch regardless; I wouldn't have noticed it.

#4 @johnjamesjacoby
15 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [2066]) Fixes #1221 props DJPaul

Note: See TracTickets for help on using tickets.