Skip to:
Content

BuddyPress.org

Opened 17 years ago

Closed 17 years ago

#1221 closed defect (bug) (fixed)

xprofile xprofile_insert_field - description arg wrong

Reported by: DJPaul Owned by: johnjamesjacoby
Priority: minor Milestone: 1.2
Component: Version:
Severity: Keywords: xprofile, has-patch
Cc:

Description

xprofile_insert_field()

line 832 needs to be
$field->desc = $description;

and not
$field->description = $description;

Attachments (1)

rename-desc-to-description.patch​ (6.1 KB ) - added by johnjamesjacoby 17 years ago.
xprofile desc to description

Download all attachments as: .zip

Change History (5)

#1 @johnjamesjacoby
17 years ago

  • Keywords has-patch added
  • Owner set to johnjamesjacoby
  • Status new → assigned

Renaming everything else the other way around makes more sense because it brings it in line with the database table column named 'description' and also bp-groups, which uses ->description.

@johnjamesjacoby
17 years ago

xprofile desc to description

#2 @DJPaul
17 years ago

Indeed but didn't have time to patch it so just reported the minimum.

#3 @johnjamesjacoby
17 years ago

Was a good catch regardless; I wouldn't have noticed it.

#4 @johnjamesjacoby
17 years ago

  • Resolution → fixed
  • Status assigned → closed

(In [2066]) Fixes #1221 props DJPaul

Note: See TracTickets for help on using tickets.