#1060 closed defect (bug) (fixed)
bp_forums_get_topic_details should get topic meta so bp template tags work
Reported by: | junsuijin | Owned by: | junsuijin |
---|---|---|---|
Milestone: | 1.1 | Priority: | minor |
Severity: | Version: | ||
Component: | Keywords: | has-patch, tested | |
Cc: |
Description
bp_forums_get_topic_details does not get the topic meta, due to some strange effect of bbPress' bb_append_meta i think. I'm unable to track exactly why this doesn't work as expected using bbPress' get_topic. The given patch allows for bp_forums_get_topic_details to get the topic meta along with the other topic details, setting up a topic the same as bp_has_forum_topics does, and thus allowing the bp template tags like bp_the_topic_object_permalink to function properly.
Attachments (2)
Change History (8)
#3
@
15 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Found that this is still an issue on all singular group pages and group subpages. The provided patch fixes the issue by applying the group filters to the forum topic query (even when there is a current group in the bp global). It also handles the fact that adding those filters will still not return the necessary data for the actual current group.
#4
@
15 years ago
I don't want to add group specific code to the get_topic function since this will tie forums exclusively to groups (outside of the directory). Actually, the code in that function was not needed, the filter on the SQL just needed to apply to the group pages as well as the directory. Please test this fix.
(In [1936]) Fixes #1060 props junsuijin