Skip to:

Opened 15 years ago

Closed 15 years ago

#1050 closed defect (bug) (fixed)

Fix activity filter links

Reported by: johnjamesjacoby's profile johnjamesjacoby Owned by: johnjamesjacoby's profile johnjamesjacoby
Milestone: 1.1 Priority: major
Severity: Version:
Component: Keywords: has-patch


Because add_query_arg() uses $_SERVERREQUEST_URI? directly and not from a passed link or variable, the previous method was removing arguments that would get immediately added again inside the loop.

This method rearranges the order a bit and relies on add_query_arg() to return the URI, and also removes the acpage from the filter links.

Previously acpage would still get passed, causing an unintended jump to filtered pages (i.e. - if status updates have 6 pages and groups have 2, changing filters causes a page-not-found.)

Attachments (1)

activity-filter-links2.patch (1.2 KB) - added by johnjamesjacoby 15 years ago.
Fix bp_get_activity_filter_links pagination issue

Download all attachments as: .zip

Change History (2)

15 years ago

Fix bp_get_activity_filter_links pagination issue

#1 @apeatling
15 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1911]) Fixes #1050 props jjj

Note: See TracTickets for help on using tickets.