Inconsistence between param name in xprofile_insert_field() and BP_XProfile_Field attribute

[luka.bernardi]

xprofile_insert_field() expect an assoc array, one of this key is field_group_id and is mapped in BP_XProfile_Field with

$field->field_group_id = $field_group_id;

but field_group_id isn't an BP_XProfile_Field's attribute nor a column in wp-bp-xprofile-field table.
Instead of field_group_id use group_id

[apeatling]

(In [1898]) Fixes #1026 props luka.bernardi

[luka.bernardi]

Can I suggest to accept group_id as a key of the array,otherwise the naming conventions could become inconsistent?

[apeatling]

Yes.

[apeatling]

Actually, I'm not sure exactly what you mean looking at it now. The member var in the field class is group_id, and so is the field in the DB. I don't really want to change that. Everyone will be interfacing with the class through the xprofile_insert_field() function, so it shouldn't matter a great deal.