Skip to:
Content

BuddyPress.org

Opened 13 years ago

Closed 13 years ago

#1026 closed defect (bug) (fixed)

Inconsistence between param name in xprofile_insert_field() and BP_XProfile_Field attribute

Reported by: lukabernardi's profile luka.bernardi Owned by:
Milestone: 1.1 Priority: minor
Severity: Version:
Component: Keywords:
Cc:

Description

xprofile_insert_field() expect an assoc array, one of this key is field_group_id and is mapped in BP_XProfile_Field with

$field->field_group_id = $field_group_id;

but field_group_id isn't an BP_XProfile_Field's attribute nor a column in wp-bp-xprofile-field table.
Instead of field_group_id use group_id

Change History (5)

#1 @djpaul
13 years ago

  • Milestone set to 1.1
  • Priority changed from major to minor

#2 @apeatling
13 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [1898]) Fixes #1026 props luka.bernardi

#3 @luka.bernardi
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Can I suggest to accept group_id as a key of the array,otherwise the naming conventions could become inconsistent?

#5 @apeatling
13 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Actually, I'm not sure exactly what you mean looking at it now. The member var in the field class is group_id, and so is the field in the DB. I don't really want to change that. Everyone will be interfacing with the class through the xprofile_insert_field() function, so it shouldn't matter a great deal.

Note: See TracTickets for help on using tickets.