Skip to:
Content

Opened 10 years ago

Closed 9 years ago

#1004 closed enhancement (no action required)

When sending a message, the ajax status text is not translatable.

Reported by: slaFFik Owned by: slaFFik
Milestone: 1.2 Priority: minor
Severity: Version:
Component: Keywords: javascript, ajax, translation, localization, need-dev-input
Cc: Jason_JM

Description

Didn't find an existent ticket, so created a new one with thus problem.
When a person is answering on smbd's message (hi/she has opened it and typed a text in a form) and clicking Send Reply -> - the ajax blue box is opened with the text "Sending Message...". I didn't find this text anywhere in bp-messages folder or pot file.
It's somewhere in javascript? Could it be checked and made translatable?

Change History (2)

#1 @Jason_JM
10 years ago

  • Cc Jason_JM added
  • Keywords javascript ajax need-dev-input added
  • Milestone changed from 1.1 to 1.2
  • Priority changed from major to minor
  • Summary changed from Sending Message text is not translatable to When sending a message, the ajax status text is not translatable.
  • Type changed from defect to enhancement

Verified.

However, this is 'hard-coded' in bp-themes/bp-sn-parent/_inc/js/ajax.js

Proposals:
1.) Dependent on language, load a hard-coded language dependent js file with $someVar="Sending message";
2.) Dependent on language, load a generated language dependent js file with $someVar="Sending message" via a pot?
3.) Code ajax.js to look for and select the first found embedded html generated by php:
<div id="ajaxLang" style="display:none visible:hidden">

<span id="ajaxLang_SendMessage" class="ajaxLang_English">Sending Message</span>

</div>

Need to talk about this item.

Flagging this as an enhancement and milestone 1.2.

#2 @DJPaul
9 years ago

  • Resolution set to invalid
  • Status changed from new to closed

I can't see "Sending message" in BP 1.2-RC2. We have accommodated this sort of thing in bp-default/functions.php bp_dtheme_js_terms(). Please reopen with location and current string if this remains an issue somewhere.

Note: See TracTickets for help on using tickets.