Changeset 9962 for trunk/tests/phpunit/testcases/core/template/bpCreateExcerpt.php

Timestamp:

06/23/2015 01:42:40 PM (10 years ago)

Author:

boonebgorges

Message:

Improve the HTML-handling logic of bp_create_excerpt().

• The regular expression that detects tags should be less generous, to avoid false matches.
• Word boundary detection, as used when exact=false, should never return a space character inside of an HTML tag (such as the space in <a href="http://example.com">).

These changes fix some tag-parsing issues introduced in [9523].

Fixes #6517.

File:

• trunk/tests/phpunit/testcases/core/template/bpCreateExcerpt.php (modified) (1 diff)

trunk/tests/phpunit/testcases/core/template/bpCreateExcerpt.php

@@ -62 +62 @@
         ) ) );
     }
+
+    /**
+     * @ticket BP6517
+     */
+    public function test_string_should_not_be_cut_mid_tag_when_exact_is_false() {
+        $text = '<p><span>Foo</span> <a href="http://example.com">Bar</a> Baz.</p><p>Foo Bar Baz</p>';
+        $actual = bp_create_excerpt( $text, 7, array(
+            'html' => true,
+            'ending' => '',
+            'exact' => false,
+        ) );
+        $this->assertSame( '<p><span>Foo</span> <a href="http://example.com">Bar</a></p>', $actual );
+    }
 }