Changeset 9955

Timestamp:

06/20/2015 01:23:47 PM (9 years ago)

Author:

boonebgorges

Message:

Improve the flexibility of the separators in the action links of the groups and members widgets.

• Introduce filters 'bp_groups_widget_separator' and 'bp_members_widget_separator' to allow customization of the default pipe character.
• Wrap separators in a <span> element, to allow for custom styling and proper ARIA role.

Props dunhakdis, pareshradadiya, hnla.
Fixes #6513.

Location:

trunk/src

Files:

• bp-groups/bp-groups-widgets.php (modified) (2 diffs)
• bp-members/bp-members-widgets.php (modified) (2 diffs)

trunk/src/bp-groups/bp-groups-widgets.php

@@ -73 +73 @@
         $title = apply_filters( 'widget_title', $instance['title'], $instance, $this->id_base );
 
+        /**
+         * Filters the separator of the group widget links.
+         *
+         * @since BuddyPress (2.4.0)
+         *
+         * @param string $separator Separator string. Default '|'.
+         */
+        $separator = apply_filters( 'bp_groups_widget_separator', '|' );
+
         echo $before_widget;
 
@@ -90 +99 @@
         <?php if ( bp_has_groups( $group_args ) ) : ?>
             <div class="item-options" id="groups-list-options">
-                <a href="<?php bp_groups_directory_permalink(); ?>" id="newest-groups"<?php if ( $instance['group_default'] == 'newest' ) : ?> class="selected"<?php endif; ?>><?php _e("Newest", 'buddypress') ?></a> |
-                <a href="<?php bp_groups_directory_permalink(); ?>" id="recently-active-groups"<?php if ( $instance['group_default'] == 'active' ) : ?> class="selected"<?php endif; ?>><?php _e("Active", 'buddypress') ?></a> |
+                <a href="<?php bp_groups_directory_permalink(); ?>" id="newest-groups"<?php if ( $instance['group_default'] == 'newest' ) : ?> class="selected"<?php endif; ?>><?php _e("Newest", 'buddypress') ?></a>
+                <span class="bp-separator" role="separator"><?php echo esc_html( $separator ); ?></span>
+                <a href="<?php bp_groups_directory_permalink(); ?>" id="recently-active-groups"<?php if ( $instance['group_default'] == 'active' ) : ?> class="selected"<?php endif; ?>><?php _e("Active", 'buddypress') ?></a>
+                <span class="bp-separator" role="separator"><?php echo esc_html( $separator ); ?></span>
                 <a href="<?php bp_groups_directory_permalink(); ?>" id="popular-groups" <?php if ( $instance['group_default'] == 'popular' ) : ?> class="selected"<?php endif; ?>><?php _e("Popular", 'buddypress') ?></a>
             </div>

trunk/src/bp-members/bp-members-widgets.php

@@ -76 +76 @@
         $title = apply_filters( 'widget_title', $settings['title'], $settings, $this->id_base );
         $title = $settings['link_title'] ? '<a href="' . bp_get_members_directory_permalink() . '">' . $title . '</a>' : $title;
+
+        /**
+         * Filters the separator of the member widget links.
+         *
+         * @since BuddyPress (2.4.0)
+         *
+         * @param string $separator Separator string. Default '|'.
+         */
+        $separator = apply_filters( 'bp_members_widget_separator', '|' );
 
         // Output before widget HTMl, title (and maybe content before & after it)
@@ -97 +106 @@
             <div class="item-options" id="members-list-options">
                 <a href="<?php bp_members_directory_permalink(); ?>" id="newest-members" <?php if ( 'newest' === $settings['member_default'] ) : ?>class="selected"<?php endif; ?>><?php esc_html_e( 'Newest', 'buddypress' ); ?></a>
-                |  <a href="<?php bp_members_directory_permalink(); ?>" id="recently-active-members" <?php if ( 'active' === $settings['member_default'] ) : ?>class="selected"<?php endif; ?>><?php esc_html_e( 'Active', 'buddypress' ); ?></a>
+                <span class="bp-separator" role="separator"><?php echo esc_html( $separator ); ?></span>
+                <a href="<?php bp_members_directory_permalink(); ?>" id="recently-active-members" <?php if ( 'active' === $settings['member_default'] ) : ?>class="selected"<?php endif; ?>><?php esc_html_e( 'Active', 'buddypress' ); ?></a>
 
                 <?php if ( bp_is_active( 'friends' ) ) : ?>
-
-                    | <a href="<?php bp_members_directory_permalink(); ?>" id="popular-members" <?php if ( 'popular' === $settings['member_default'] ) : ?>class="selected"<?php endif; ?>><?php esc_html_e( 'Popular', 'buddypress' ); ?></a>
+                    <span class="bp-separator" role="separator"><?php echo esc_html( $separator ); ?></span>
+                    <a href="<?php bp_members_directory_permalink(); ?>" id="popular-members" <?php if ( 'popular' === $settings['member_default'] ) : ?>class="selected"<?php endif; ?>><?php esc_html_e( 'Popular', 'buddypress' ); ?></a>
 
                 <?php endif; ?>