Changeset 9936 for trunk/src/bp-xprofile/bp-xprofile-template.php

Timestamp:

06/11/2015 06:53:59 AM (10 years ago)

Author:

johnjamesjacoby

Message:

Loaders: Micro-optimizations:

• Add brackets for improved readability
• Only instantiate $bp from buddypress() when used more than once, and after all early return conditions have executed
• Use _slug_ functions where appropriate, and avoid $this->slug references as they do not run filters
• Reduce mulitple calls to the same functions into 1 function call: I.E. bp_core_can_edit_settings()
• Remove BP_Core_Component::setup_nav() method - it's been handled and duplicated by BP_Members_Component for several years now, and only when XProfile is disabled
• Use new bp_get_profile_slug() functions where appropriate
• Use bp_core_number_format() where appropriate
• Avoid duplicate trailingslashit() calls on the same variables
• Rely on canonical menu URLs for all components

This change touches each component's -loader.php file and makes several small optimizations that avoid executing hundreds of function calls that return data (specifically gettext) that never gets used on logged-out users. This results in an approximate 20% reduction in time spent running our full unit test suite in my testing, and also improves site performance for logged-out users.

File:

• trunk/src/bp-xprofile/bp-xprofile-template.php (modified) (5 diffs)

trunk/src/bp-xprofile/bp-xprofile-template.php

@@ -522 +522 @@
          *                      profile group edit form.
          */
-        return apply_filters( 'bp_get_the_profile_group_edit_form_action', trailingslashit( bp_displayed_user_domain() . $bp->profile->slug . '/edit/group/' . $group->id ) );
+        return apply_filters( 'bp_get_the_profile_group_edit_form_action', trailingslashit( bp_displayed_user_domain() . bp_get_profile_slug() . '/edit/group/' . $group->id ) );
     }
 
@@ -1029 +1029 @@
 
         // Build the profile field group link
-        $link   = trailingslashit( bp_displayed_user_domain() . buddypress()->profile->slug . '/edit/group/' . $groups[ $i ]->id );
+        $link   = trailingslashit( bp_displayed_user_domain() . bp_get_profile_slug() . '/edit/group/' . $groups[ $i ]->id );
 
         // Add tab to end of tabs array
@@ -1136 +1136 @@
 }
     function bp_get_avatar_delete_link() {
-        $bp = buddypress();
 
         /**
@@ -1145 +1144 @@
          * @param string $value Nonced URL used for deleting an avatar.
          */
-        return apply_filters( 'bp_get_avatar_delete_link', wp_nonce_url( bp_displayed_user_domain() . $bp->profile->slug . '/change-avatar/delete-avatar/', 'bp_delete_avatar_link' ) );
+        return apply_filters( 'bp_get_avatar_delete_link', wp_nonce_url( bp_displayed_user_domain() . bp_get_profile_slug() . '/change-avatar/delete-avatar/', 'bp_delete_avatar_link' ) );
     }
 
 function bp_edit_profile_button() {
-    $bp = buddypress();
-
     bp_button( array(
         'id'                => 'edit_profile',
@@ -1156 +1153 @@
         'must_be_logged_in' => true,
         'block_self'        => true,
-        'link_href'         => trailingslashit( bp_displayed_user_domain() . $bp->profile->slug . '/edit' ),
+        'link_href'         => trailingslashit( bp_displayed_user_domain() . bp_get_profile_slug() . '/edit' ),
         'link_class'        => 'edit',
         'link_text'         => __( 'Edit Profile', 'buddypress' ),