Changeset 9936 for trunk/src/bp-members/bp-members-loader.php

Timestamp:

06/11/2015 06:53:59 AM (11 years ago)

Author:

johnjamesjacoby

Message:

Loaders: Micro-optimizations:

• Add brackets for improved readability
• Only instantiate $bp from buddypress() when used more than once, and after all early return conditions have executed
• Use _slug_ functions where appropriate, and avoid $this->slug references as they do not run filters
• Reduce mulitple calls to the same functions into 1 function call: I.E. bp_core_can_edit_settings()
• Remove BP_Core_Component::setup_nav() method - it's been handled and duplicated by BP_Members_Component for several years now, and only when XProfile is disabled
• Use new bp_get_profile_slug() functions where appropriate
• Use bp_core_number_format() where appropriate
• Avoid duplicate trailingslashit() calls on the same variables
• Rely on canonical menu URLs for all components

This change touches each component's -loader.php file and makes several small optimizations that avoid executing hundreds of function calls that return data (specifically gettext) that never gets used on logged-out users. This results in an approximate 20% reduction in time spent running our full unit test suite in my testing, and also improves site performance for logged-out users.

File:

• trunk/src/bp-members/bp-members-loader.php (modified) (3 diffs)

trunk/src/bp-members/bp-members-loader.php

@@ -142 +142 @@
                 /** Profiles Fallback *************************************************/
 
-                if ( !bp_is_active( 'xprofile' ) ) {
+                if ( ! bp_is_active( 'xprofile' ) ) {
                         $bp->profile       = new stdClass;
                         $bp->profile->slug = 'profile';
@@ -231 +231 @@
                 }
 
-                $bp = buddypress();
+                // Determine user to use
+                if ( bp_displayed_user_domain() ) {
+                        $user_domain = bp_displayed_user_domain();
+                } elseif ( bp_loggedin_user_domain() ) {
+                        $user_domain = bp_loggedin_user_domain();
+                } else {
+                        return;
+                }
+
+                $slug         = bp_get_profile_slug();
+                $profile_link = trailingslashit( $user_domain . $slug );
 
                 // Setup the main navigation
                 $main_nav = array(
                         'name'                => _x( 'Profile', 'Member profile main navigation', 'buddypress' ),
-                        'slug'                => $bp->profile->slug,
+                        'slug'                => $slug,
                         'position'            => 20,
                         'screen_function'     => 'bp_members_screen_display_profile',
                         'default_subnav_slug' => 'public',
-                        'item_css_id'         => $bp->profile->id
-                );
-
-                // User links
-                $user_domain  = bp_displayed_user_domain() ? bp_displayed_user_domain() : bp_loggedin_user_domain();
-                $profile_link = trailingslashit( $user_domain . $bp->profile->slug );
+                        'item_css_id'         => buddypress()->profile->id
+                );
 
                 // Setup the subnav items for the member profile
@@ -252 +258 @@
                         'slug'            => 'public',
                         'parent_url'      => $profile_link,
-                        'parent_slug'     => $bp->profile->slug,
+                        'parent_slug'     => $slug,
                         'screen_function' => 'bp_members_screen_display_profile',
                         'position'        => 10