Changeset 9936 for trunk/src/bp-blogs/bp-blogs-loader.php

Timestamp:

06/11/2015 06:53:59 AM (11 years ago)

Author:

johnjamesjacoby

Message:

Loaders: Micro-optimizations:

• Add brackets for improved readability
• Only instantiate $bp from buddypress() when used more than once, and after all early return conditions have executed
• Use _slug_ functions where appropriate, and avoid $this->slug references as they do not run filters
• Reduce mulitple calls to the same functions into 1 function call: I.E. bp_core_can_edit_settings()
• Remove BP_Core_Component::setup_nav() method - it's been handled and duplicated by BP_Members_Component for several years now, and only when XProfile is disabled
• Use new bp_get_profile_slug() functions where appropriate
• Use bp_core_number_format() where appropriate
• Avoid duplicate trailingslashit() calls on the same variables
• Rely on canonical menu URLs for all components

This change touches each component's -loader.php file and makes several small optimizations that avoid executing hundreds of function calls that return data (specifically gettext) that never gets used on logged-out users. This results in an approximate 20% reduction in time spent running our full unit test suite in my testing, and also improves site performance for logged-out users.

File:

• trunk/src/bp-blogs/bp-blogs-loader.php (modified) (9 diffs)

trunk/src/bp-blogs/bp-blogs-loader.php

@@ -144 +144 @@
          */
         public function setup_nav( $main_nav = array(), $sub_nav = array() ) {
-                $bp = buddypress();
 
                 /**
@@ -155 +154 @@
                 }
 
-                // Add 'Sites' to the main navigation
-                $count    = (int) bp_get_total_blog_count_for_user();
-                $class    = ( 0 === $count ) ? 'no-count' : 'count';
-                $nav_text = sprintf( __( 'Sites <span class="%s">%s</span>', 'buddypress' ), esc_attr( $class ), number_format_i18n( $count )  );
-                $main_nav = array(
-                        'name'                => $nav_text,
-                        'slug'                => $this->slug,
-                        'position'            => 30,
-                        'screen_function'     => 'bp_blogs_screen_my_blogs',
-                        'default_subnav_slug' => 'my-sites',
-                        'item_css_id'         => $this->id
-                );
-
                 // Determine user to use
                 if ( bp_displayed_user_domain() ) {
@@ -177 +163 @@
                 }
 
-                $parent_url = trailingslashit( $user_domain . bp_get_blogs_slug() );
+                $slug       = bp_get_blogs_slug();
+                $parent_url = trailingslashit( $user_domain . $slug );
+
+                // Add 'Sites' to the main navigation
+                $count    = (int) bp_get_total_blog_count_for_user();
+                $class    = ( 0 === $count ) ? 'no-count' : 'count';
+                $nav_text = sprintf( __( 'Sites <span class="%s">%s</span>', 'buddypress' ), esc_attr( $class ), bp_core_number_format( $count )  );
+                $main_nav = array(
+                        'name'                => $nav_text,
+                        'slug'                => $slug,
+                        'position'            => 30,
+                        'screen_function'     => 'bp_blogs_screen_my_blogs',
+                        'default_subnav_slug' => 'my-sites',
+                        'item_css_id'         => $this->id
+                );
 
                 $sub_nav[] = array(
@@ -183 +183 @@
                         'slug'            => 'my-sites',
                         'parent_url'      => $parent_url,
-                        'parent_slug'     => $bp->blogs->slug,
+                        'parent_slug'     => $slug,
                         'screen_function' => 'bp_blogs_screen_my_blogs',
                         'position'        => 10
@@ -203 +203 @@
          */
         public function setup_admin_bar( $wp_admin_nav = array() ) {
-                $bp = buddypress();
 
                 /**
@@ -217 +216 @@
                 if ( is_user_logged_in() ) {
 
-                        $blogs_link = trailingslashit( bp_loggedin_user_domain() . $this->slug );
+                        // Setup the logged in user variables
+                        $blogs_link = trailingslashit( bp_loggedin_user_domain() . bp_get_blogs_slug() );
 
                         // Add the "Sites" sub menu
                         $wp_admin_nav[] = array(
-                                'parent' => $bp->my_account_menu_id,
+                                'parent' => buddypress()->my_account_menu_id,
                                 'id'     => 'my-account-' . $this->id,
                                 'title'  => __( 'Sites', 'buddypress' ),
-                                'href'   => trailingslashit( $blogs_link )
+                                'href'   => $blogs_link
                         );
 
@@ -232 +232 @@
                                 'id'     => 'my-account-' . $this->id . '-my-sites',
                                 'title'  => __( 'My Sites', 'buddypress' ),
-                                'href'   => trailingslashit( $blogs_link )
+                                'href'   => $blogs_link
                         );
 
@@ -253 +253 @@
          */
         public function setup_title() {
-                $bp = buddypress();
 
                 // Set up the component options navigation for Site
                 if ( bp_is_blogs_component() ) {
+                        $bp = buddypress();
+
                         if ( bp_is_my_profile() ) {
                                 if ( bp_is_active( 'xprofile' ) ) {
@@ -300 +301 @@
          */
         public function post_tracking_args( $params = null, $post_type = 0 ) {
+
                 /**
                  * Filters the post types to track for the Blogs component.