Changeset 9887 for trunk/src/bp-notifications/classes/class-bp-notifications-notification.php

Timestamp:

05/21/2015 07:56:59 PM (10 years ago)

Author:

johnjamesjacoby

Message:

Notifications: Improve all_for_user cache deletion.

• Introduce bp_notification_before_update action which fires before a Notification is updated
• Introduce bp_notifications_clear_all_for_user_cache() as wrapper for wp_cache_delete() with appropriate cache group and key
• Introduce bp_notifications_clear_all_for_user_cache_before_update() hooked to bp_notification_before_update action, to handle cache deletion before a notification is updated

This change fixes a bug where marking single notifications as read/unread would not show anticipated results, as the all_for_user cache was not being properly cleared.

Props r-a-y. Fixes #6445.

File:

• trunk/src/bp-notifications/classes/class-bp-notifications-notification.php (modified) (1 diff)

trunk/src/bp-notifications/classes/class-bp-notifications-notification.php

@@ -831 +831 @@
         $where  = self::get_query_clauses( $where_args  );
 
-        // make sure we delete the notification cache for the user on update
-        if ( ! empty( $where_args['user_id'] ) ) {
-            wp_cache_delete( 'all_for_user_' . $where_args['user_id'], 'bp_notifications' );
-        }
-
-        return self::_update( $update['data'], $where['data'], $update['format'], $where['format'] );
+        /**
+         * Fires before the update of a notification item.
+         *
+         * @since BuddyPress (2.3.0)
+         *
+         * @param array $update_args See BP_Notifications_Notification::update().
+         * @param array $where_args  See BP_Notifications_Notification::update().
+         */
+        do_action( 'bp_notification_before_update', $update_args, $where_args );
+
+        return self::_update(
+            $update['data'],
+            $where['data'],
+            $update['format'],
+            $where['format']
+        );
     }