Skip to:
Content

Changeset 9856


Ignore:
Timestamp:
05/09/2015 08:44:25 AM (3 years ago)
Author:
hnla
Message:

Update twentyfourteen SCSS Sheet
Commit addresses scss-lint tests for VendorPrefix (currently disallowed by config)

  • Uncomment vendor prefix properties previously removed as failing tests.
  • Add scss-lint disable/enable block rules.
  • Moves any mixins with vendor prefix properties within the exclusion block.
  • Add calc() mixin from twentyfifteen sheet(props r-a-y)

Vendor prefix usage such as 'border-radius', 'box-sizing' will now pass tests as long as they are only used via a mixin within this exclusion block; this allows us to pass vendor prefixes where we explicitly set them in our exclusion block but then allows the lint test to run through on the rest of the sheet so ensuring prefixes aren't written directly to rulesets.
See #6338

Location:
trunk/src/bp-templates/bp-legacy/css
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-templates/bp-legacy/css/twentyfourteen-rtl.css

    r9842 r9856  
    102102      border: 1px solid rgba(0, 0, 0, 0.2);
    103103      border-bottom-color: #fff;
     104      -webkit-border-top-left-radius: 4px;
    104105      border-top-left-radius: 4px;
     106      -webkit-border-top-right-radius: 4px;
    105107      border-top-right-radius: 4px;
    106108      background-clip: padding-box;
     
    248250        display: block; }
    249251        #buddypress ul.item-list li .action div a {
     252          -webkit-box-sizing: border-box;
     253          -moz-box-sizing: border-box;
    250254          box-sizing: border-box;
    251255          display: block;
     
    386390#buddypress .members .item-list .my-entry .item {
    387391  background: #f7f7f7;
     392  -webkit-box-sizing: border-box;
     393  -moz-box-sizing: border-box;
    388394  box-sizing: border-box;
    389395  padding: 0 0.5em; }
  • trunk/src/bp-templates/bp-legacy/css/twentyfourteen.css

    r9842 r9856  
    102102      border: 1px solid rgba(0, 0, 0, 0.2);
    103103      border-bottom-color: #fff;
     104      -webkit-border-top-right-radius: 4px;
    104105      border-top-right-radius: 4px;
     106      -webkit-border-top-left-radius: 4px;
    105107      border-top-left-radius: 4px;
    106108      background-clip: padding-box;
     
    248250        display: block; }
    249251        #buddypress ul.item-list li .action div a {
     252          -webkit-box-sizing: border-box;
     253          -moz-box-sizing: border-box;
    250254          box-sizing: border-box;
    251255          display: block;
     
    386390#buddypress .members .item-list .my-entry .item {
    387391  background: #f7f7f7;
     392  -webkit-box-sizing: border-box;
     393  -moz-box-sizing: border-box;
    388394  box-sizing: border-box;
    389395  padding: 0 0.5em; }
  • trunk/src/bp-templates/bp-legacy/css/twentyfourteen.scss

    r9842 r9856  
    3838}
    3939
     40// To allow mixins to pass VendorPrefix scss-lint tests we disable lint-test
     41// for specific blocks / rulesets
     42// until such time as exemption lists can be built for the scss-lint.yml?
     43// Any vendor prefix properties / mixins need to be in this block
     44// scss-lint:disable VendorPrefix
     45
    4046// Border border-radius mixins
    41 // To allow mixins to pass cscc-lint tests we will not provide vendor prefix
    42 // until such time as exemption lists can be built for the scss-lint.yml
    43 
    4447@mixin border-radius($radius) {
    45 //  -webkit-border-radius: $radius;
    46 //  -moz-border-radius: $radius;
    47 //  -ms-border-radius: $radius;
     48    -webkit-border-radius: $radius;
     49    -moz-border-radius: $radius;
     50    -ms-border-radius: $radius;
    4851    border-radius: $radius;
    4952    background-clip: padding-box;
     
    5154
    5255@mixin border-top-radius($radius) {
    53 //  -webkit-border-top-right-radius: $radius;
     56    -webkit-border-top-right-radius: $radius;
    5457    border-top-right-radius: $radius;
    55 //  -webkit-border-top-left-radius: $radius;
     58    -webkit-border-top-left-radius: $radius;
    5659    border-top-left-radius: $radius;
    5760    background-clip: padding-box;
     
    5962
    6063@mixin border-right-radius($radius) {
    61 //  -webkit-border-bottom-right-radius: $radius;
     64    -webkit-border-bottom-right-radius: $radius;
    6265    border-bottom-right-radius: $radius;
    63 //  -webkit-border-top-right-radius: $radius;
     66    -webkit-border-top-right-radius: $radius;
    6467    border-top-right-radius: $radius;
    6568    background-clip: padding-box;
     
    6770
    6871@mixin border-bottom-radius($radius) {
    69 //  -webkit-border-bottom-right-radius: $radius;
     72    -webkit-border-bottom-right-radius: $radius;
    7073    border-bottom-right-radius: $radius;
    71 //  -webkit-border-bottom-left-radius: $radius;
     74    -webkit-border-bottom-left-radius: $radius;
    7275    border-bottom-left-radius: $radius;
    7376    background-clip: padding-box;
     
    7578
    7679@mixin border-left-radius($radius) {
    77 //  -webkit-border-bottom-left-radius: $radius;
     80    -webkit-border-bottom-left-radius: $radius;
    7881    border-bottom-left-radius: $radius;
    79 //  -webkit-border-top-left-radius: $radius;
     82    -webkit-border-top-left-radius: $radius;
    8083    border-top-left-radius: $radius;
    8184    background-clip: padding-box;
     
    8386
    8487// Box sizing
    85 
    8688@mixin box-model($box-model: border-box) {
    87 //  -webkit-box-sizing: $box-model;
    88 //  -moz-box-sizing: $box-model;
     89    -webkit-box-sizing: $box-model;
     90    -moz-box-sizing: $box-model;
    8991    box-sizing: $box-model;
    9092}
     93
     94// Calc
     95@mixin calc($property, $expression) {
     96    #{$property}: -webkit-calc(#{$expression});
     97    #{$property}: -moz-calc(#{$expression});
     98    #{$property}: calc(#{$expression});
     99}
     100
     101// Re-enable the VendorPrefix lint test
     102// scss-lint:enable VendorPrefix
    91103
    92104// BP message boxes
Note: See TracChangeset for help on using the changeset viewer.