Changeset 9837

Timestamp:

05/04/2015 07:31:24 PM (11 years ago)

Author:

imath

Message:

Make sure tracked post types registered using the bp_blogs_record_post_post_types filter will have the same activity tracking arguments than the post post type.

Since 2.2.0, and the introduction of the custom post types activities feature, when a post type was registered using the bp_blogs_record_post_post_types filter it had specific tracking arguments. It introduced some inconsistency as soon as the filter bp_blogs_record_comment_post_types was also used to track comments about this post type and when the activity/comment syncing feature was on.

From now on, post types registering to Site tracking using the filter bp_blogs_record_post_post_types will automatically get the same tracking arguments than the post post type to fix this inconsistency.

Props shanebp, boonebgorges

Fixes #6306

Location:

trunk

Files:

• src/bp-blogs/bp-blogs-loader.php (modified) (2 diffs)
• tests/phpunit/testcases/blogs/filters.php (added)

trunk/src/bp-blogs/bp-blogs-loader.php

@@ -86 +86 @@
 
                         /**
-                         * Filters the post types to track for the Blog component.
+                         * Filters the post types to track for the Blogs component.
                          *
                          * @since BuddyPress (1.5.0)
+                         * @deprecated BuddyPress (2.3.0)
                          *
                          * @param array $value Array of post types to track.
@@ -298 +299 @@
          * @see bp_activity_get_post_type_tracking_args() for information on parameters.
          */
-        public function post_tracking_args( $params = array(), $post_type = 0 ) {
-                if ( 'post' != $post_type ) {
+        public function post_tracking_args( $params = null, $post_type = 0 ) {
+                /**
+                 * Filters the post types to track for the Blogs component.
+                 *
+                 * @since BuddyPress (1.5.0)
+                 * @deprecated BuddyPress (2.3.0)
+                 *
+                 * Make sure plugins still using 'bp_blogs_record_post_post_types'
+                 * to track their post types will generate new_blog_post activities
+                 * See https://buddypress.trac.wordpress.org/ticket/6306
+                 *
+                 * @param array $value Array of post types to track.
+                 */
+                $post_types = apply_filters( 'bp_blogs_record_post_post_types', array( 'post' ) );
+                $post_types_array = array_flip( $post_types );
+
+                if ( ! isset( $post_types_array[ $post_type ] ) ) {
                         return $params;
                 }