Changeset 9815

Timestamp:

04/28/2015 03:50:50 PM (11 years ago)

Author:

r-a-y

Message:

Groups: Streamline last activity update meta calls.

This commit:

• Removes the hardcoded 'last_activity' call in groups_join_group() and uses the groups_update_last_activity() on the 'groups_join_group' hook. This mirrors last activity update calls on other group actions (leave, created).
• Removes the hardcoded 'last_activity' call in groups_create_group(). The last activity is already updated on the 'groups_created_group' hook. No need to update twice!

Props jreeve.

Fixes #6158.

Location:

trunk/src/bp-groups

Files:

• bp-groups-activity.php (modified) (1 diff)
• bp-groups-functions.php (modified) (3 diffs)

trunk/src/bp-groups/bp-groups-activity.php

@@ -401 +401 @@
         groups_update_groupmeta( $group_id, 'last_activity', bp_core_current_time() );
 }
+add_action( 'groups_join_group',           'groups_update_last_activity' );
 add_action( 'groups_leave_group',          'groups_update_last_activity' );
 add_action( 'groups_created_group',        'groups_update_last_activity' );

trunk/src/bp-groups/bp-groups-functions.php

@@ -166 +166 @@
                 $member->save();
 
-                groups_update_groupmeta( $group->id, 'last_activity', bp_core_current_time() );
-
                 /**
                  * Fires after the creation of a new group and a group creator needs to be made.
@@ -194 +192 @@
 
         /**
-         * Fires after the creation of a group.
+         * Fires after the creation or update of a group.
          *
          * @since BuddyPress (1.0.0)
@@ -501 +499 @@
                 'user_id' => $user_id,
         ) );
-
-        // Modify group meta
-        groups_update_groupmeta( $group_id, 'last_activity', bp_core_current_time() );
 
         /**